From: Christoph Hellwig <hch@lst.de>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/3] compat: copy missing fields in compat_statfs64 to user
Date: Mon, 27 Dec 2010 16:36:15 +0100 [thread overview]
Message-ID: <20101227153615.GB22676@lst.de> (raw)
In-Reply-To: <1293381714-5264-3-git-send-email-namhyung@gmail.com>
On Mon, Dec 27, 2010 at 01:41:54AM +0900, Namhyung Kim wrote:
> f_flags and f_spare fields were not copied to userspace when
> compat_sys_[f]statfs64 called.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> Cc: Christoph Hellwig <hch@lst.de>
> ---
> It seems struct compat_statfs lacks the f_flags field in it but I'm not
> sure whether it is intended or not. Is it useful if I make a patch for
> it too?
Looks good. We discussed this a while back before it fell under the
table again.
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2010-12-27 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 16:41 [PATCH 1/3] compat: remove unnecessary assignment in compat_rw_copy_check_uvector() Namhyung Kim
2010-12-26 16:41 ` [PATCH 2/3] compat: update comment of compat statfs syscalls Namhyung Kim
2010-12-26 16:41 ` [PATCH 3/3] compat: copy missing fields in compat_statfs64 to user Namhyung Kim
2010-12-27 15:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101227153615.GB22676@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).