linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: akpm <akpm@linux-foundation.org>, viro <viro@zeniv.linux.org.uk>
Subject: [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK
Date: Sat, 1 Jan 2011 22:17:16 -0800	[thread overview]
Message-ID: <20110101221716.70ef7f5a.randy.dunlap@oracle.com> (raw)

From: Randy Dunlap <randy.dunlap@oracle.com>

- Fix a kconfig unmet dependency warning.
- Update the comment that identifies which filesystems use POSIX ACL
  utility routines.
- Move the FS_POSIX_ACL symbol outside of the BLOCK symbol if/endif block
  because its functions do not depend on BLOCK and some of the filesystems
  that use it do not depend on BLOCK.

warning: (GENERIC_ACL && JFFS2_FS_POSIX_ACL && NFSD_V4 && NFS_ACL_SUPPORT && 9P_FS_POSIX_ACL) selects FS_POSIX_ACL which has unmet direct dependencies (BLOCK)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
---
 fs/Kconfig |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

--- linux-next-20101231.orig/fs/Kconfig
+++ linux-next-20101231/fs/Kconfig
@@ -30,15 +30,6 @@ config FS_MBCACHE
 source "fs/reiserfs/Kconfig"
 source "fs/jfs/Kconfig"
 
-config FS_POSIX_ACL
-# Posix ACL utility routines (for now, only ext2/ext3/jfs/reiserfs/nfs4)
-#
-# NOTE: you can implement Posix ACLs without these helpers (XFS does).
-# 	Never use this symbol for ifdefs.
-#
-	bool
-	default n
-
 source "fs/xfs/Kconfig"
 source "fs/gfs2/Kconfig"
 source "fs/ocfs2/Kconfig"
@@ -47,6 +38,15 @@ source "fs/nilfs2/Kconfig"
 
 endif # BLOCK
 
+config FS_POSIX_ACL
+# Posix ACL utility routines
+# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p)
+#
+# NOTE: you can implement Posix ACLs without these helpers.
+# 	Never use this symbol for ifdefs.
+#
+	def_bool n
+
 config EXPORTFS
 	tristate
 

             reply	other threads:[~2011-01-02  6:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-02  6:17 Randy Dunlap [this message]
2011-01-02  6:29 ` [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK Christoph Hellwig
2011-01-02  9:39   ` Marco Stornelli
2011-01-02 22:44     ` [PATCH v2] " Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110101221716.70ef7f5a.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).