From: Christoph Hellwig <hch@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, akpm <akpm@linux-foundation.org>,
viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK
Date: Sun, 2 Jan 2011 01:29:48 -0500 [thread overview]
Message-ID: <20110102062948.GA582@infradead.org> (raw)
In-Reply-To: <20110101221716.70ef7f5a.randy.dunlap@oracle.com>
On Sat, Jan 01, 2011 at 10:17:16PM -0800, Randy Dunlap wrote:
> +config FS_POSIX_ACL
> +# Posix ACL utility routines
> +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p)
> +#
> +# NOTE: you can implement Posix ACLs without these helpers.
> +# Never use this symbol for ifdefs.
> +#
> + def_bool n
> +
I'd drop the list of filesystems, and move the comment above the symbol,
e.g:
#
# Posix ACL utility routines
#
# Note: Posix ACLs can be implemented without these helpers. Never use
# this symbol for ifdefs in core code.
#
config FS_POSIX_ACL
def_bool n
next prev parent reply other threads:[~2011-01-02 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 6:17 [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK Randy Dunlap
2011-01-02 6:29 ` Christoph Hellwig [this message]
2011-01-02 9:39 ` Marco Stornelli
2011-01-02 22:44 ` [PATCH v2] " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110102062948.GA582@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).