* [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK
@ 2011-01-02 6:17 Randy Dunlap
2011-01-02 6:29 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2011-01-02 6:17 UTC (permalink / raw)
To: linux-fsdevel; +Cc: akpm, viro
From: Randy Dunlap <randy.dunlap@oracle.com>
- Fix a kconfig unmet dependency warning.
- Update the comment that identifies which filesystems use POSIX ACL
utility routines.
- Move the FS_POSIX_ACL symbol outside of the BLOCK symbol if/endif block
because its functions do not depend on BLOCK and some of the filesystems
that use it do not depend on BLOCK.
warning: (GENERIC_ACL && JFFS2_FS_POSIX_ACL && NFSD_V4 && NFS_ACL_SUPPORT && 9P_FS_POSIX_ACL) selects FS_POSIX_ACL which has unmet direct dependencies (BLOCK)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
---
fs/Kconfig | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--- linux-next-20101231.orig/fs/Kconfig
+++ linux-next-20101231/fs/Kconfig
@@ -30,15 +30,6 @@ config FS_MBCACHE
source "fs/reiserfs/Kconfig"
source "fs/jfs/Kconfig"
-config FS_POSIX_ACL
-# Posix ACL utility routines (for now, only ext2/ext3/jfs/reiserfs/nfs4)
-#
-# NOTE: you can implement Posix ACLs without these helpers (XFS does).
-# Never use this symbol for ifdefs.
-#
- bool
- default n
-
source "fs/xfs/Kconfig"
source "fs/gfs2/Kconfig"
source "fs/ocfs2/Kconfig"
@@ -47,6 +38,15 @@ source "fs/nilfs2/Kconfig"
endif # BLOCK
+config FS_POSIX_ACL
+# Posix ACL utility routines
+# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p)
+#
+# NOTE: you can implement Posix ACLs without these helpers.
+# Never use this symbol for ifdefs.
+#
+ def_bool n
+
config EXPORTFS
tristate
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK
2011-01-02 6:17 [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK Randy Dunlap
@ 2011-01-02 6:29 ` Christoph Hellwig
2011-01-02 9:39 ` Marco Stornelli
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2011-01-02 6:29 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-fsdevel, akpm, viro
On Sat, Jan 01, 2011 at 10:17:16PM -0800, Randy Dunlap wrote:
> +config FS_POSIX_ACL
> +# Posix ACL utility routines
> +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p)
> +#
> +# NOTE: you can implement Posix ACLs without these helpers.
> +# Never use this symbol for ifdefs.
> +#
> + def_bool n
> +
I'd drop the list of filesystems, and move the comment above the symbol,
e.g:
#
# Posix ACL utility routines
#
# Note: Posix ACLs can be implemented without these helpers. Never use
# this symbol for ifdefs in core code.
#
config FS_POSIX_ACL
def_bool n
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK
2011-01-02 6:29 ` Christoph Hellwig
@ 2011-01-02 9:39 ` Marco Stornelli
2011-01-02 22:44 ` [PATCH v2] " Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Marco Stornelli @ 2011-01-02 9:39 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Randy Dunlap, linux-fsdevel, akpm, viro
Il 02/01/2011 07:29, Christoph Hellwig ha scritto:
> On Sat, Jan 01, 2011 at 10:17:16PM -0800, Randy Dunlap wrote:
>> +config FS_POSIX_ACL
>> +# Posix ACL utility routines
>> +# (for now, ext2/ext3/ext4/jfs/jffs2/reiserfs/xfs/btrfs/gfs2/ocfs2/nfs4/9p)
>> +#
>> +# NOTE: you can implement Posix ACLs without these helpers.
>> +# Never use this symbol for ifdefs.
>> +#
>> + def_bool n
>> +
>
> I'd drop the list of filesystems, and move the comment above the symbol,
> e.g:
>
> #
> # Posix ACL utility routines
> #
> # Note: Posix ACLs can be implemented without these helpers. Never use
> # this symbol for ifdefs in core code.
> #
> config FS_POSIX_ACL
> def_bool n
>
I agree, the list can be a maintaince overhead.
Marco
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] fs: FS_POSIX_ACL does not depend on BLOCK
2011-01-02 9:39 ` Marco Stornelli
@ 2011-01-02 22:44 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2011-01-02 22:44 UTC (permalink / raw)
To: linux-fsdevel; +Cc: Christoph Hellwig, akpm, viro, Marco Stornelli
From: Randy Dunlap <randy.dunlap@oracle.com>
- Fix a kconfig unmet dependency warning.
- Remove the comment that identifies which filesystems use POSIX ACL
utility routines.
- Move the FS_POSIX_ACL symbol outside of the BLOCK symbol if/endif block
because its functions do not depend on BLOCK and some of the filesystems
that use it do not depend on BLOCK.
warning: (GENERIC_ACL && JFFS2_FS_POSIX_ACL && NFSD_V4 && NFS_ACL_SUPPORT && 9P_FS_POSIX_ACL) selects FS_POSIX_ACL which has unmet direct dependencies (BLOCK)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
---
fs/Kconfig | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
--- linux-next-20101231.orig/fs/Kconfig
+++ linux-next-20101231/fs/Kconfig
@@ -30,15 +30,6 @@ config FS_MBCACHE
source "fs/reiserfs/Kconfig"
source "fs/jfs/Kconfig"
-config FS_POSIX_ACL
-# Posix ACL utility routines (for now, only ext2/ext3/jfs/reiserfs/nfs4)
-#
-# NOTE: you can implement Posix ACLs without these helpers (XFS does).
-# Never use this symbol for ifdefs.
-#
- bool
- default n
-
source "fs/xfs/Kconfig"
source "fs/gfs2/Kconfig"
source "fs/ocfs2/Kconfig"
@@ -47,6 +38,14 @@ source "fs/nilfs2/Kconfig"
endif # BLOCK
+# Posix ACL utility routines
+#
+# Note: Posix ACLs can be implemented without these helpers. Never use
+# this symbol for ifdefs in core code.
+#
+config FS_POSIX_ACL
+ def_bool n
+
config EXPORTFS
tristate
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-02 22:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-02 6:17 [PATCH] fs: FS_POSIX_ACL does not depend on BLOCK Randy Dunlap
2011-01-02 6:29 ` Christoph Hellwig
2011-01-02 9:39 ` Marco Stornelli
2011-01-02 22:44 ` [PATCH v2] " Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).