From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH][rfc] xattr acl: Suspicious use of potentially null
 pointer.
Date: Fri, 7 Jan 2011 02:47:57 +0300
Message-ID: <20110106234750.GB1761@bicker>
References: <alpine.LNX.2.00.1101062247420.13988@swampdragon.chaosbits.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>
To: Jesper Juhl <jj@chaosbits.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:35246 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751625Ab1AFXsl (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 6 Jan 2011 18:48:41 -0500
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1101062247420.13988@swampdragon.chaosbits.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jan 06, 2011 at 10:52:22PM +0100, Jesper Juhl wrote:
> 
> In posix_acl_from_xattr() we have this at the head of the function:
> 
>   		posix_acl_xattr_header *header = (posix_acl_xattr_header *)value;
>    		posix_acl_xattr_entry *entry = (posix_acl_xattr_entry *)(header+1), *end;
> 
> Since 'value' is passed in by the caller and may be NULL, the second line 
> looks suspicious to me - taking a potentially NULL pointer (at least 
> btrfs will pass something allocated with kmalloc() which may be NULL), 
> adding one to it and casting it does not seem like it would always be such 
> a hot idea.

The original code is fine.

regards,
dan carpenter