From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [patch 8/8] fs: add i_op->sync_inode Date: Tue, 11 Jan 2011 14:44:34 +1100 Message-ID: <20110111034434.GB5271@amd> References: <20101229151246.GA22033@infradead.org> <20110104062725.GD3402@amd> <20110104065736.GA8013@infradead.org> <20110104080323.GC4090@amd> <20110104083132.GA4485@amd> <20110104092541.GC2760@infradead.org> <20110104095231.GB4812@amd> <20110106204911.GB2872@infradead.org> <20110107044836.GB4552@amd> <20110107072510.GB32308@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nick Piggin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton To: Christoph Hellwig Return-path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:52882 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580Ab1AKDoh (ORCPT ); Mon, 10 Jan 2011 22:44:37 -0500 Content-Disposition: inline In-Reply-To: <20110107072510.GB32308@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 07, 2011 at 02:25:10AM -0500, Christoph Hellwig wrote: > On Fri, Jan 07, 2011 at 03:48:36PM +1100, Nick Piggin wrote: > > OK, I don't exactly see why a sync_inode with appropriate flag could > > not solve that problem. I'll take a bit more look through nfs and > > xfs. Thanks... > > We could also overload all inode operations into a single ioctl like > method, but that doesn't make it a good design. I've been a bit busy lately and haven't had time to continue this discussion. Thanks for your input so far, and I'll get back to it soon. I will try to get out a set of changes for current merge window that fix the bulk of the problems without going into areas you disagree with, and then we can have a smaller set of changes we to agree on for next merge window. I will come back and reply to your points when I get a bit more time.