From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v3] mm: add replace_page_cache_page() function Date: Tue, 11 Jan 2011 23:25:28 +0900 Message-ID: <20110111142528.GF2113@barrios-desktop> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jan 11, 2011 at 03:07:54PM +0100, Miklos Szeredi wrote: > (resent with fixed CC list, sorry for the duplicate) > > Thanks for the review. > > Here's an updated patch. Modifications since the last post: > > - don't pass gfp_mask (since it's only able to deal with GFP_KERNEL > anyway) > I am not sure it's a good idea. Now if we need just GFP_KERNEL, we can't make sure it in future. Sometime we might need GFP_ATOMIC and friendd functions (ex, add_to_page_cache_lru,add_to_page_cache_locked) already have gfp_mask. It's a exported function so it's hard to modify it in future. I want to keep it. Instead of removing it, we can change mem_cgroup_prepare_migration as getting gfp_mask. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org