From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karel Zak Subject: Re: [dm-devel] linux-next - WARNING: at fs/block_dev.c:824 bd_link_disk_holder+0x92/0x1ac() Date: Thu, 13 Jan 2011 14:26:37 +0100 Message-ID: <20110113132637.GH16523@nb.net.home> References: <16069.1294853673@localhost> <4D2E4611.90002@redhat.com> <4D2E6129.8000700@ce.jp.nec.com> <20110113110640.GC30719@htj.dyndns.org> <4D2EE156.1050006@redhat.com> <20110113122701.GG16523@nb.net.home> <20110113131216.GF30719@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Milan Broz , device-mapper development , "Jun'ichi Nomura" , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Kay Sievers To: Tejun Heo Return-path: Content-Disposition: inline In-Reply-To: <20110113131216.GF30719@htj.dyndns.org> Sender: linux-raid-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jan 13, 2011 at 02:12:16PM +0100, Tejun Heo wrote: > Hello, > > On Thu, Jan 13, 2011 at 01:27:01PM +0100, Karel Zak wrote: > > We also use holders/slaves links in libblkid to evaluate dependencies > > between devices (since 2008). > > > > > Whatever changes are needed, please keep this functionality, it > > > can be useful. > > > > Definitely. > > Yeah, sure, it's not like I can afford to avoid fixing it at this > point anyway, but I still want to point out it's at the wrong layer > and shouldn't have been added like this, really. If you want blkid to > identify it, the proper thing to do would be querying blk device for > the claimer and then use claimer-specific method to query them. It's It seems that dependencies (holders/slaves) between devices is pretty generic thing. Why do you think that we need claimer-specific method? The /sys filesystem is better that ictls in many ways. > not like the current method would make sense for btrfs or whatnot. Could you be more verbose, please? Karel -- Karel Zak http://karelzak.blogspot.com