From: Josef Bacik <josef@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, josef@redhat.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] make the feature checks in ->fallocate future proof
Date: Fri, 14 Jan 2011 08:05:16 -0500 [thread overview]
Message-ID: <20110114130515.GA2558@localhost.localdomain> (raw)
In-Reply-To: <20110114120730.GA13936@lst.de>
On Fri, Jan 14, 2011 at 01:07:30PM +0100, Christoph Hellwig wrote:
> Instead of various home grown checks that might need updates for new
> flags just check for any bit outside the mask of the features supported
> by the filesystem. This makes the check future proof for any newly
> added flag.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
Reviewed-by: Josef Bacik <josef@redhat.com>
Thanks,
Josef
prev parent reply other threads:[~2011-01-14 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 12:07 [PATCH 1/2] make the feature checks in ->fallocate future proof Christoph Hellwig
2011-01-14 13:05 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114130515.GA2558@localhost.localdomain \
--to=josef@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).