From: Al Viro <viro@ZenIV.linux.org.uk>
To: Nick Piggin <npiggin@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
npiggin@kernel.dk, raven@themaw.net, autofs@linux.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/18] Add a dentry op to handle automounting rather than abusing follow_link()
Date: Fri, 14 Jan 2011 16:24:03 +0000 [thread overview]
Message-ID: <20110114162403.GF19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AANLkTi=ZiOZ08WEkTt8nVWkaeSG9mnM0JQ-ov=kO2mpc@mail.gmail.com>
On Fri, Jan 14, 2011 at 12:19:43PM +1100, Nick Piggin wrote:
> Also, I don't like how you return a vfsmount * and use that in path walking. If
> you just returned success and allowed the path walk to continue looking up
> mounted directories, it would be cleaner code, IMO.
No. Filesystem has no business touching mount tree; leave that to core VFS.
Analysis of what's going on is messy enough as it is, let's *NOT* complicate
it even further.
I think we should take do_add_mount() calls into follow_automount(), making
the API
NULL => nothing to do here, just follow mount
ERR_PTR() => sod off
mnt => here's the thing I want mounted, do it and go there. If
something's allready got mounted here, just disregard this one and follow
mount as usual (== we'd lost the race)
next prev parent reply other threads:[~2011-01-14 16:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 17:48 [PATCH 00/18] Introduce automount support in the VFS David Howells
2011-01-11 17:48 ` [PATCH 01/18] Add a dentry op to handle automounting rather than abusing follow_link() David Howells
2011-01-13 3:53 ` Nick Piggin
2011-01-13 5:10 ` Nick Piggin
2011-01-13 15:12 ` David Howells
2011-01-14 1:19 ` Nick Piggin
2011-01-14 16:24 ` Al Viro [this message]
2011-01-14 22:14 ` Nick Piggin
2011-01-13 12:20 ` David Howells
2011-01-14 1:04 ` Nick Piggin
2011-01-14 9:24 ` David Howells
2011-01-11 17:48 ` [PATCH 02/18] AFS: Use d_automount() " David Howells
2011-01-11 17:48 ` [PATCH 03/18] NFS: " David Howells
2011-01-11 17:48 ` [PATCH 04/18] CIFS: " David Howells
2011-01-11 17:48 ` [PATCH 05/18] Remove the automount through follow_link() kludge code from pathwalk David Howells
2011-01-11 17:48 ` [PATCH 06/18] Add an AT_NO_AUTOMOUNT flag to suppress terminal automount David Howells
2011-01-11 17:48 ` [PATCH 07/18] Add more dentry flags for special function directories David Howells
2011-01-11 17:48 ` [PATCH 08/18] Make follow_down() handle d_manage() David Howells
2011-01-11 17:48 ` [PATCH 09/18] autofs4: Add d_automount() dentry operation David Howells
2011-01-11 17:49 ` [PATCH 10/18] autofs4: Add d_manage() " David Howells
2011-01-11 17:49 ` [PATCH 11/18] autofs4: Remove unused code David Howells
2011-01-11 17:49 ` [PATCH 12/18] autofs4: Clean up inode operations David Howells
2011-01-11 17:49 ` [PATCH 13/18] autofs4: Clean up dentry operations David Howells
2011-01-11 17:49 ` [PATCH 14/18] autofs4: Clean up autofs4_free_ino() David Howells
2011-01-11 17:49 ` [PATCH 15/18] autofs4: Fix wait validation David Howells
2011-01-11 17:49 ` [PATCH 16/18] autofs4: Add v4 pseudo direct mount support David Howells
2011-01-11 17:49 ` [PATCH 17/18] autofs4: Bump version David Howells
2011-01-11 17:49 ` [PATCH 18/18] Remove a further kludge from __do_follow_link() David Howells
2011-01-12 13:52 ` [PATCH 07/18] Add more dentry flags for special function directories [UPDATE] David Howells
2011-01-12 19:16 ` [PATCH 00/18] Introduce automount support in the VFS David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114162403.GF19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=autofs@linux.kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=npiggin@kernel.dk \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).