From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vitaliy Gusev <gusev.vitaliy@gmail.com>
Cc: Trond.Myklebust@netapp.com, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [nfs] Oops during call nfs_mountpoint_inode_operations->lookup() method
Date: Mon, 17 Jan 2011 22:18:46 +0000 [thread overview]
Message-ID: <20110117221846.GJ22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AANLkTimO_YkQ4bjNb9rp=xyuo2KvHdm8Xk7GE-3vet+g@mail.gmail.com>
On Mon, Jan 17, 2011 at 08:04:02PM +0300, Vitaliy Gusev wrote:
> diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c
> index db6aa36..c5f9162 100644
> --- a/fs/nfs/namespace.c
> +++ b/fs/nfs/namespace.c
> @@ -177,10 +177,16 @@ out_follow:
> const struct inode_operations nfs_mountpoint_inode_operations = {
> .follow_link = nfs_follow_mountpoint,
> .getattr = nfs_getattr,
> +#ifdef CONFIG_NFS_V4
> + .lookup = nfs_atomic_lookup,
> +#endif
> };
>
> const struct inode_operations nfs_referral_inode_operations = {
> .follow_link = nfs_follow_mountpoint,
> +#ifdef CONFIG_NFS_V4
> + .lookup = nfs_atomic_lookup,
> +#endif
> };
That looks very wrong. You are papering over the real problem here - ask
yourself what would that ->lookup() be expected to do?
The thing is, we shouldn't end up trying to call ->lookup() for those.
That's the real issue...
next prev parent reply other threads:[~2011-01-17 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 16:55 [nfs] Oops during call nfs_mountpoint_inode_operations->lookup() method Vitaliy Gusev
2011-01-17 17:04 ` Vitaliy Gusev
2011-01-17 22:18 ` Al Viro [this message]
2011-01-18 22:59 ` Vitaliy Gusev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117221846.GJ22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=gusev.vitaliy@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).