From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ian Kent <raven@themaw.net>
Cc: Nick Piggin <npiggin@suse.de>,
David Howells <dhowells@redhat.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] vfs - fix dentry ref count in do_lookup()
Date: Tue, 18 Jan 2011 04:44:14 +0000 [thread overview]
Message-ID: <20110118044414.GK22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110118040610.23109.32868.stgit@localhost6.localdomain6>
On Tue, Jan 18, 2011 at 12:06:10PM +0800, Ian Kent wrote:
> There is a ref count problem in fs/namei.c:do_lookup().
>
> When walking in ref-walk mode, if follow_managed() returns a fail the
> reference held by path.dentry isn't dropped.
If we get to follow_managed(), we *are* in ref-walk mode. Unconditionally.
Besided, that's path_put_conditional(), not dput() - we might have both
grabbed vfsmount on mountpoint crossing *AND* changed dentry.
Applied with modifications...
The rest applied as-is.
next prev parent reply other threads:[~2011-01-18 4:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 4:05 [PATCH 0/3] Fixes for vfs-scale and vfs-automount Ian Kent
2011-01-18 4:06 ` [PATCH 1/3] autofs4 - fix get_next_positive_dentry() Ian Kent
2011-01-18 4:06 ` [PATCH 2/3] vfs - fix dentry ref count in do_lookup() Ian Kent
2011-01-18 4:44 ` Al Viro [this message]
2011-01-18 4:06 ` [PATCH 3/3] autofs4 - fix debug print in autofs4_lookup() Ian Kent
2011-01-19 7:06 ` [PATCH 0/3] Fixes for vfs-scale and vfs-automount Ian Kent
2011-02-15 14:25 ` Ian Kent
2011-02-23 7:22 ` Ian Kent
2011-02-23 16:37 ` Linus Torvalds
2011-02-24 1:58 ` Al Viro
2011-02-24 3:03 ` Ian Kent
2011-02-24 3:14 ` Al Viro
[not found] ` <20110224031439.GR22723-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2011-02-24 3:28 ` Ian Kent
2011-02-24 3:58 ` Al Viro
2011-02-24 5:47 ` Al Viro
2011-02-24 7:23 ` Ian Kent
[not found] ` <20110224035836.GS22723-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2011-02-24 6:34 ` Ian Kent
2011-02-24 7:07 ` Al Viro
[not found] ` <20110224070724.GW22723-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2011-02-24 10:07 ` Ian Kent
2011-02-24 14:59 ` Al Viro
2011-02-24 15:18 ` Al Viro
2011-02-25 3:07 ` Ian Kent
2011-02-24 19:10 ` Al Viro
2011-02-24 10:21 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118044414.GK22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).