linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>,
	Tao Ma <tm@tao.ma>, Nick Piggin <npiggin@kernel.dk>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>,
	Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] VFS: call synchronize_rcu after kill_sb.
Date: Tue, 8 Feb 2011 23:50:07 -0500	[thread overview]
Message-ID: <20110209045007.GA29650@infradead.org> (raw)
In-Reply-To: <4D517C98.7060000@panasas.com>

> +		/*
> +		 * We need to synchronize rcu here so that
> +		 * the delayed rcu inode free can be executed
> +		 * before we put_super.
> +		 * https://bugzilla.kernel.org/show_bug.cgi?id=27652
> +		 */

URLs in comments are not useful, descriptions of the issues in comments
should be complete enough to understand the issue.  I think the comment
without the url is enough, though.


  parent reply	other threads:[~2011-02-09  4:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05  9:01 [PATCH] VFS: call synchronize_rcu after kill_sb Tao Ma
2011-02-07 13:14 ` Boaz Harrosh
2011-02-08 16:57   ` Aneesh Kumar K. V
2011-02-08 17:25     ` Boaz Harrosh
2011-02-09  1:49       ` Tao Ma
2011-02-09  4:50       ` Christoph Hellwig [this message]
2011-02-09  8:26         ` [PATCH] VFS: call rcu_barrier " Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209045007.GA29650@infradead.org \
    --to=hch@infradead.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bharrosh@panasas.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=npiggin@kernel.dk \
    --cc=tm@tao.ma \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).