From: Al Viro <viro@ZenIV.linux.org.uk>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: LOOKUP_CREATE checks in nfs ->create() instances
Date: Thu, 17 Feb 2011 03:37:30 +0000 [thread overview]
Message-ID: <20110217033730.GI22723@ZenIV.linux.org.uk> (raw)
When are they _not_ true? AFAICS, calls of ->create() with
non-NULL nameidata are very limited to start with:
* ecryptfs one - called from its own ->create(), without changes
in LOOKUP_CREATE presence.
* sys_mknodat() - called after we'd done lookup_create(), which
sets LOOKUP_CREATE (and LOOKUP_EXCL), with O_EXCL in intent flags. Nothing
ever removes LOOKUP_CREATE once it's set.
* __open_namei_create(), which is called from from do_filp_open()
and only if we had O_CREAT passed in flags. In that case LOOKUP_CREATE
will be set before we get there.
What am I missing here? AFAICS, there's no way to get nfs ->create() methods
called without LOOKUP_CREATE present in nd->flags...
next reply other threads:[~2011-02-17 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 3:37 Al Viro [this message]
2011-02-17 19:07 ` LOOKUP_CREATE checks in nfs ->create() instances Trond Myklebust
2011-02-17 19:50 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217033730.GI22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).