From: Al Viro <viro@ZenIV.linux.org.uk>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: LOOKUP_CREATE checks in nfs ->create() instances
Date: Thu, 17 Feb 2011 19:50:55 +0000 [thread overview]
Message-ID: <20110217195055.GK22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1297969620.2964.8.camel@heimdal.trondhjem.org>
On Thu, Feb 17, 2011 at 02:07:00PM -0500, Trond Myklebust wrote:
> Hi Al,
>
> That is probably a remnant of the times before lookup_create() was
> changed to set the LOOKUP_CREATE intent in 2.6.18.
>
> I'm fine with getting rid of those checks if they are no longer needed.
Um... You mean, before we had .open.flags set to O_EXCL in there?
Makes sense - it's about 3 years older than lookup_create() change.
OK, then I'm going to remove the checks (treating condition as always
true) and place BUG_ON for a few months just in case...
prev parent reply other threads:[~2011-02-17 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 3:37 LOOKUP_CREATE checks in nfs ->create() instances Al Viro
2011-02-17 19:07 ` Trond Myklebust
2011-02-17 19:50 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217195055.GK22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).