From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: LOOKUP_CREATE checks in nfs ->create() instances
Date: Thu, 17 Feb 2011 19:50:55 +0000
Message-ID: <20110217195055.GK22723@ZenIV.linux.org.uk>
References: <20110217033730.GI22723@ZenIV.linux.org.uk>
 <1297969620.2964.8.camel@heimdal.trondhjem.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:40713 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752333Ab1BQTu4 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 17 Feb 2011 14:50:56 -0500
Content-Disposition: inline
In-Reply-To: <1297969620.2964.8.camel@heimdal.trondhjem.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Feb 17, 2011 at 02:07:00PM -0500, Trond Myklebust wrote:

> Hi Al,
> 
> That is probably a remnant of the times before lookup_create() was
> changed to set the LOOKUP_CREATE intent in 2.6.18.
> 
> I'm fine with getting rid of those checks if they are no longer needed.

Um...  You mean, before we had .open.flags set to O_EXCL in there?
Makes sense - it's about 3 years older than lookup_create() change.
OK, then I'm going to remove the checks (treating condition as always
true) and place BUG_ON for a few months just in case...