From: Christoph Hellwig <hch@infradead.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
cluster-devel@redhat.com,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH] Check for immutable flag in fallocate path
Date: Mon, 21 Feb 2011 07:46:35 -0500 [thread overview]
Message-ID: <20110221124635.GA5525@infradead.org> (raw)
In-Reply-To: <4D6221B8.9040303@gmail.com>
On Mon, Feb 21, 2011 at 09:26:32AM +0100, Marco Stornelli wrote:
> From: Marco Stornelli <marco.stornelli@gmail.com>
>
> All fs must check for the immutable flag in their fallocate callback.
> It's possible to have a race condition in this scenario: an application
> open a file in read/write and it does something, meanwhile root set the
> immutable flag on the file, the application at that point can call
> fallocate with success. Only Ocfs2 check for the immutable flag at the
> moment.
Please add the check in fs/open.c:do_fallocate() so that it covers all
filesystems.
next prev parent reply other threads:[~2011-02-21 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 8:26 [PATCH] Check for immutable flag in fallocate path Marco Stornelli
2011-02-21 12:46 ` Christoph Hellwig [this message]
2011-02-21 16:50 ` Marco Stornelli
2011-02-27 22:49 ` Ted Ts'o
2011-02-28 7:53 ` Marco Stornelli
2011-03-02 8:19 ` Marco Stornelli
2011-02-26 14:59 ` Marco Stornelli
2011-03-03 8:42 ` [PATCH v2] " Marco Stornelli
2011-03-03 21:39 ` Dave Chinner
2011-03-04 8:17 ` Marco Stornelli
2011-03-04 12:18 ` Marco Stornelli
2011-03-14 10:24 ` Christoph Hellwig
2011-03-14 10:40 ` Marco Stornelli
2011-03-05 9:37 ` [PATCH v3] Check for immutable/append " Marco Stornelli
2011-03-05 10:00 ` Sedat Dilek
2011-03-05 10:10 ` [PATCH v3][RESEND] " Marco Stornelli
2011-03-09 19:42 ` Marco Stornelli
2011-03-09 21:27 ` Greg KH
2011-03-10 12:03 ` Marco Stornelli
2011-03-08 5:11 ` [PATCH v3] " Dave Chinner
2011-03-08 5:38 ` Andreas Dilger
2011-03-08 7:35 ` Marco Stornelli
2011-03-09 1:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221124635.GA5525@infradead.org \
--to=hch@infradead.org \
--cc=cluster-devel@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).