From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] st_nlink after rmdir() and rename()
Date: Thu, 3 Mar 2011 04:42:42 +0000 [thread overview]
Message-ID: <20110303044242.GJ22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110303032454.GI22723@ZenIV.linux.org.uk>
On Thu, Mar 03, 2011 at 03:24:54AM +0000, Al Viro wrote:
> 0 0: ext*, xfs, jfs, reiserfs, ocfs2, gfs2, nilfs, exofs, udf, ubifs,
> minix, sysv, ufs, msdos, vfat, hfs+
> 0 1: ramfs, shmem, hugetlbfs, jffs2, omfs, hfs[*], apparently nfs as well
> [*] yes, different from hfs+; the code is clearly broken, since it simply
> does unlink() on target, without even verifying that it's empty. And
> yes, it's trivial fs corruption...
Actually, hfs turns out to be 0 0 as well; it *is* broken (lacks check
for target being empty), but when the target is empty it's doing the
right thing. jffs2 and ramfs-based ones do 0 1 - confirmed by direct
experiment.
next prev parent reply other threads:[~2011-03-03 4:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 3:24 [RFC] st_nlink after rmdir() and rename() Al Viro
2011-03-03 4:42 ` Al Viro [this message]
2011-03-03 5:17 ` Linus Torvalds
2011-03-03 6:03 ` Al Viro
2011-03-03 20:05 ` Linus Torvalds
2011-03-03 20:46 ` OGAWA Hirofumi
2011-03-03 20:50 ` OGAWA Hirofumi
2011-03-03 21:02 ` Linus Torvalds
2011-03-03 21:30 ` Al Viro
2011-03-03 21:37 ` OGAWA Hirofumi
2011-03-03 21:52 ` Linus Torvalds
2011-03-03 22:26 ` OGAWA Hirofumi
2011-03-03 22:37 ` Linus Torvalds
2011-03-03 23:14 ` OGAWA Hirofumi
2011-03-03 23:12 ` Al Viro
2011-03-03 22:57 ` Al Viro
2011-03-03 23:07 ` Al Viro
2011-03-04 6:55 ` omfs fixes Al Viro
2011-03-04 15:24 ` Bob Copeland
2011-03-03 21:23 ` [RFC] st_nlink after rmdir() and rename() Al Viro
2011-03-03 14:34 ` Theodore Tso
2011-03-03 16:17 ` Andreas Schwab
2011-03-03 19:16 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303044242.GJ22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).