From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tony Luck <tony.luck@intel.com>
Cc: Xiaotian Feng <xtfeng@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)
Date: Thu, 17 Mar 2011 22:42:52 +0000 [thread overview]
Message-ID: <20110317224252.GC22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4d827eae305473e2bf@agluck-desktop.sc.intel.com>
On Thu, Mar 17, 2011 at 02:35:42PM -0700, Tony Luck wrote:
> mutex_unlock(&root->d_inode->i_mutex);
>
> - if (!pstore_writefile(inode, dentry, data, size))
> - goto fail_write;
> + memcpy(private->data, data, size);
> + inode->i_size = private->size = size;
>
> inode->i_private = private;
Better move that before d_add()
> if (IS_ERR(root))
> - return -ENOMEM;
> -
> - mnt->mnt_root = root;
> - mnt->mnt_sb = root->d_sb;
> - pstore_mnt = mnt;
> + return root;
>
> - return 0;
> + return root;
*blink*
if (IS_ERR(root))
return root;
return root;
... or am I misreading the patch?
next prev parent reply other threads:[~2011-03-17 22:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 23:56 [git pull] mnt_devname queue Al Viro
2011-03-17 5:45 ` Xiaotian Feng
2011-03-17 7:23 ` Al Viro
2011-03-17 7:28 ` Xiaotian Feng
2011-03-17 10:44 ` Al Viro
2011-03-17 19:08 ` Tony Luck
2011-03-17 21:35 ` Some fixes for pstore (Was Re: [git pull] mnt_devname queue) Tony Luck
2011-03-17 22:42 ` Al Viro [this message]
2011-03-17 22:48 ` Tony Luck
2011-03-17 22:56 ` Al Viro
2011-03-17 23:29 ` Tony Luck
2011-03-18 0:07 ` Al Viro
2011-03-18 18:44 ` pstore: fix leaking ->i_private Luck, Tony
2011-03-18 18:49 ` Christoph Hellwig
2011-03-18 18:55 ` Tony Luck
2011-03-18 22:33 ` pstore: use mount option instead sysfs to tweak kmsg_bytes Luck, Tony
2011-03-18 18:57 ` pstore: fix leaking ->i_private Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317224252.GC22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=xtfeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).