From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejun Heo <tj@kernel.org>
Subject: Re: [patch] block: NULL dereference on error path in __blkdev_get()
Date: Fri, 18 Mar 2011 09:32:02 +0100
Message-ID: <20110318083202.GC8571@htj.dyndns.org>
References: <20110313205937.GI2008@bicker>
 <20110314085819.GJ2005@htj.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Dan Carpenter <error27@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-fx0-f46.google.com ([209.85.161.46]:45172 "EHLO
	mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753025Ab1CRIcu (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 18 Mar 2011 04:32:50 -0400
Content-Disposition: inline
In-Reply-To: <20110314085819.GJ2005@htj.dyndns.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Mar 14, 2011 at 09:58:19AM +0100, Tejun Heo wrote:
> Hello,
> 
> On Sun, Mar 13, 2011 at 11:59:37PM +0300, Dan Carpenter wrote:
> > "disk" is always NULL when we goto out.  There was a check for this
> > before, but it was removed in 69e02c59a7d9 "block: Don't check events
> > while open is in progress".
> > 
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
>  Acked-by: Tejun Heo <tj@kernel.org>
> 
> Sorry about the trouble.  I hate that function.  :-(

I thought Jens was cc'd.  I'll forward the patch to him & LKML.

Thanks.

-- 
tejun