From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: pstore: fix leaking ->i_private Date: Fri, 18 Mar 2011 14:49:57 -0400 Message-ID: <20110318184957.GA6979@infradead.org> References: <20110316235608.GY22723@ZenIV.linux.org.uk> <20110317072344.GZ22723@ZenIV.linux.org.uk> <4d83a82032021e2997@agluck-desktop.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , Xiaotian Feng , Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "Luck, Tony" Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:36295 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753937Ab1CRSuA (ORCPT ); Fri, 18 Mar 2011 14:50:00 -0400 Content-Disposition: inline In-Reply-To: <4d83a82032021e2997@agluck-desktop.sc.intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Another comment on pstore: - the kmsg_bytes attribute really should be a mount option. no need have this in a completely different namespace, and require all the kobject mess around it.