From: Christoph Hellwig <hch@infradead.org>
To: Steve French <smfrench@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-cifs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [CIFS] [PATCH] consistently use smb_buf_length as be32 for cifs (try 3)
Date: Fri, 18 Mar 2011 14:51:54 -0400 [thread overview]
Message-ID: <20110318185154.GA8028@infradead.org> (raw)
In-Reply-To: <AANLkTikqrGxG1RgUwFGNhoyyLc8ARiVvqQ8ULio8pz4f@mail.gmail.com>
On Thu, Mar 17, 2011 at 12:17:24PM -0500, Steve French wrote:
> If others feel strongly about this, I don't mind changing it as
> Christoph suggests but
> - to samba people, "incrementing the rfc1001 length" would be more
> recognizable (than opencoding the be32_add_cpu macro), and the
> function name was
> actually Jeff's suggestion which I liked.
I don't mind the rfc1001 length per se. What's totally braindead about
this is having an absolutely trivial wrapper for incrementing a field,
which has a different name than the field it increments.
If you feel strongly about the rfc1001 length just rename the field.
next prev parent reply other threads:[~2011-03-18 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 16:41 [CIFS] [PATCH] consistently use smb_buf_length as be32 for cifs (try 3) Steve French
2011-03-17 16:44 ` Christoph Hellwig
2011-03-17 17:17 ` Steve French
2011-03-18 18:51 ` Christoph Hellwig [this message]
[not found] ` <20110318185154.GA8028-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-03-19 21:17 ` Jeff Layton
2011-03-20 3:05 ` Steve French
[not found] ` <AANLkTi==ojddc91ruaLHJvY85_tHvNe1J+YVZi7fsj8n-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-20 13:41 ` Jeff Layton
[not found] ` <20110320094121.39be555c-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-03-20 14:01 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318185154.GA8028@infradead.org \
--to=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).