From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, apw@canonical.com, nbd@openwrt.org,
neilb@suse.de
Subject: Re: [PATCH 0/6 v7] overlay filesystem - request for inclusion
Date: Tue, 22 Mar 2011 19:00:02 +0000 [thread overview]
Message-ID: <20110322190002.GW22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1Q26mX-0001Tt-Jq@pomaz-ex.szeredi.hu>
On Tue, Mar 22, 2011 at 07:58:17PM +0100, Miklos Szeredi wrote:
> On Tue, 22 Mar 2011, Linus Torvalds wrote:
> > On Tue, Mar 22, 2011 at 11:39 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > >
> > > Locking analysis would be really nice; AFAICS, it violates locking order
> > > when called from e.g. ->setattr()
>
> Locking order is always:
>
> -> overlayfs locks
> -> upper fs locks
> -> lower fs locks
>
> So it's really pretty simple and easy to validate.
In which *order* on the upper fs?
> Protection is exactly as for userspace callers. AFAICT.
Pardon? You traverse the chain of ancestors; fine, but who says it stays
anywhere near being relevant as you go?
next prev parent reply other threads:[~2011-03-22 19:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 15:26 [PATCH 0/6 v7] overlay filesystem - request for inclusion Miklos Szeredi
2011-03-22 15:26 ` [PATCH 1/6 v7] vfs: add i_op->open() Miklos Szeredi
2011-03-22 17:18 ` Linus Torvalds
2011-03-22 18:12 ` Miklos Szeredi
2011-03-22 18:37 ` Linus Torvalds
2011-03-22 15:26 ` [PATCH 2/6 v7] vfs: export do_splice_direct() to modules Miklos Szeredi
2011-03-22 15:26 ` [PATCH 3/6 v7] vfs: introduce clone_private_mount() Miklos Szeredi
2011-03-22 15:26 ` [PATCH 4/6 v7] overlay filesystem prototype Miklos Szeredi
2011-03-22 17:30 ` Linus Torvalds
2011-03-22 18:15 ` Miklos Szeredi
2011-03-22 15:26 ` [PATCH 5/6 v7] overlayfs: add statfs support Miklos Szeredi
2011-03-22 15:26 ` [PATCH 6/6 v7] overlay: overlay filesystem documentation Miklos Szeredi
2011-03-22 17:36 ` [PATCH 0/6 v7] overlay filesystem - request for inclusion Linus Torvalds
2011-03-22 18:22 ` Felix Fietkau
2011-03-22 18:27 ` Linus Torvalds
2011-03-22 18:39 ` Al Viro
2011-03-22 18:48 ` Linus Torvalds
2011-03-22 18:58 ` Miklos Szeredi
2011-03-22 19:00 ` Al Viro [this message]
2011-03-22 19:43 ` Miklos Szeredi
2011-03-22 19:53 ` Al Viro
2011-03-22 20:06 ` Miklos Szeredi
2011-03-22 20:11 ` Al Viro
2011-03-22 20:31 ` Miklos Szeredi
2011-03-22 20:40 ` Miklos Szeredi
2011-03-23 10:03 ` Miklos Szeredi
2011-03-22 19:38 ` Al Viro
2011-03-22 19:56 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322190002.GW22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nbd@openwrt.org \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).