linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, apw@canonical.com, nbd@openwrt.org,
	neilb@suse.de
Subject: Re: [PATCH 0/6 v7] overlay filesystem - request for inclusion
Date: Tue, 22 Mar 2011 19:38:07 +0000	[thread overview]
Message-ID: <20110322193807.GX22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1Q26mX-0001Tt-Jq@pomaz-ex.szeredi.hu>

On Tue, Mar 22, 2011 at 07:58:17PM +0100, Miklos Szeredi wrote:

> > >  and its protection against renames is
> > > nowhere near enough. ??I might be missing something subtle, but...
> 
> Protection is exactly as for userspace callers.  AFAICT.

BTW, what filesystems can act as upper layers and how are you going to
prevent modifications of upper layer in normal way?  It is mounted,
after all, or you would be unable to find it when mounting overlayfs.
And it might be mounted in any number of places, not all even visible to
you...  I realize that you have it listed as a problem, but do you have
any ideas on how to deal with that?

If you allow NFS as upper layer, you really have a problem; with this
approach you probably want to prevent that very forcibly.  Not that
your open() handling would work correctly with NFS, even with no modifications
from other clients or from server...

  parent reply	other threads:[~2011-03-22 19:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 15:26 [PATCH 0/6 v7] overlay filesystem - request for inclusion Miklos Szeredi
2011-03-22 15:26 ` [PATCH 1/6 v7] vfs: add i_op->open() Miklos Szeredi
2011-03-22 17:18   ` Linus Torvalds
2011-03-22 18:12     ` Miklos Szeredi
2011-03-22 18:37       ` Linus Torvalds
2011-03-22 15:26 ` [PATCH 2/6 v7] vfs: export do_splice_direct() to modules Miklos Szeredi
2011-03-22 15:26 ` [PATCH 3/6 v7] vfs: introduce clone_private_mount() Miklos Szeredi
2011-03-22 15:26 ` [PATCH 4/6 v7] overlay filesystem prototype Miklos Szeredi
2011-03-22 17:30   ` Linus Torvalds
2011-03-22 18:15     ` Miklos Szeredi
2011-03-22 15:26 ` [PATCH 5/6 v7] overlayfs: add statfs support Miklos Szeredi
2011-03-22 15:26 ` [PATCH 6/6 v7] overlay: overlay filesystem documentation Miklos Szeredi
2011-03-22 17:36 ` [PATCH 0/6 v7] overlay filesystem - request for inclusion Linus Torvalds
2011-03-22 18:22   ` Felix Fietkau
2011-03-22 18:27     ` Linus Torvalds
2011-03-22 18:39   ` Al Viro
2011-03-22 18:48     ` Linus Torvalds
2011-03-22 18:58       ` Miklos Szeredi
2011-03-22 19:00         ` Al Viro
2011-03-22 19:43           ` Miklos Szeredi
2011-03-22 19:53             ` Al Viro
2011-03-22 20:06               ` Miklos Szeredi
2011-03-22 20:11                 ` Al Viro
2011-03-22 20:31                   ` Miklos Szeredi
2011-03-22 20:40                     ` Miklos Szeredi
2011-03-23 10:03                     ` Miklos Szeredi
2011-03-22 19:38         ` Al Viro [this message]
2011-03-22 19:56           ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110322193807.GX22723@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=nbd@openwrt.org \
    --cc=neilb@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).