* [PATCH] ufs: remove unessecary blk_flush_plug
@ 2011-03-30 9:57 Christoph Hellwig
2011-03-30 10:18 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2011-03-30 9:57 UTC (permalink / raw)
To: dushistov, jaxboe; +Cc: linux-fsdevel
We already flush the per-process plugging list when context switching,
so a blk_flush_plug call just before a yield() is not needed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/ufs/truncate.c
===================================================================
--- xfs.orig/fs/ufs/truncate.c 2011-03-30 11:35:58.095660392 +0200
+++ xfs/fs/ufs/truncate.c 2011-03-30 11:36:03.487659988 +0200
@@ -479,7 +479,6 @@ int ufs_truncate(struct inode *inode, lo
break;
if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
ufs_sync_inode (inode);
- blk_flush_plug(current);
yield();
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ufs: remove unessecary blk_flush_plug
2011-03-30 9:57 [PATCH] ufs: remove unessecary blk_flush_plug Christoph Hellwig
@ 2011-03-30 10:18 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2011-03-30 10:18 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: dushistov@mail.ru, linux-fsdevel@vger.kernel.org
On 2011-03-30 11:57, Christoph Hellwig wrote:
> We already flush the per-process plugging list when context switching,
> so a blk_flush_plug call just before a yield() is not needed.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/ufs/truncate.c
> ===================================================================
> --- xfs.orig/fs/ufs/truncate.c 2011-03-30 11:35:58.095660392 +0200
> +++ xfs/fs/ufs/truncate.c 2011-03-30 11:36:03.487659988 +0200
> @@ -479,7 +479,6 @@ int ufs_truncate(struct inode *inode, lo
> break;
> if (IS_SYNC(inode) && (inode->i_state & I_DIRTY))
> ufs_sync_inode (inode);
> - blk_flush_plug(current);
> yield();
> }
Added for .39 merge, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-30 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-30 9:57 [PATCH] ufs: remove unessecary blk_flush_plug Christoph Hellwig
2011-03-30 10:18 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).