From: Joel Becker <jlbec@evilplan.org>
To: Josef Bacik <josef@redhat.com>
Cc: Sunil Mushran <sunil.mushran@oracle.com>,
Tristan Ye <tristan.ye@oracle.com>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
chris.mason@oracle.com, tm@tao.ma
Subject: Re: [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl().
Date: Thu, 31 Mar 2011 16:44:55 -0700 [thread overview]
Message-ID: <20110331234454.GB18808@noexit> (raw)
In-Reply-To: <20110331225618.GB7484@dhcp231-156.rdu.redhat.com>
On Thu, Mar 31, 2011 at 06:56:18PM -0400, Josef Bacik wrote:
> On Thu, Mar 31, 2011 at 02:14:43PM -0700, Sunil Mushran wrote:
> > Frankly I see no point extending the ioctl interface when we have
> > a syscall interface.
> >
>
> I'd even go so far as to say we could probably axe the xfs and ocfs2 ioctls
> since we have the fallocate interface :). Thanks,
These ioctls are in long use. Granted, it is for the small
subset of users that know xfs and ocfs2 can do this, but still.
<venkman>Breaking userspace is *bad*.</venkman>
More interesting would be to bring the ioctls up to generic code
and have them backended by fallocate. I'm not sure they map without
looking deeper, but it's at least an idea.
Joel
--
print STDOUT q
Just another Perl hacker,
unless $spring
- Larry Wall
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2011-03-31 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 7:33 [PATCH 1/3] VFS/ioctl: Add punching-hole support to ioctl() Tristan Ye
2011-03-31 21:14 ` Sunil Mushran
2011-03-31 22:56 ` Josef Bacik
2011-03-31 23:44 ` Joel Becker [this message]
2011-04-01 0:34 ` Josef Bacik
[not found] ` <20110401003450.GD7484@dhcp231-156.rdu.redhat.com>
2011-04-01 16:54 ` [Ocfs2-devel] " Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331234454.GB18808@noexit \
--to=jlbec@evilplan.org \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sunil.mushran@oracle.com \
--cc=tm@tao.ma \
--cc=tristan.ye@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).