From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [patch v2] bio-integrity: use hardware sectors instead of block
 layer sectors
Date: Tue, 5 Apr 2011 15:35:14 -0500
Message-ID: <20110405203435.GA13179@elie>
References: <20100507082928.GT27064@bicker>
 <20100507095414.GH27064@bicker>
 <yq1ljbi8i1z.fsf@sermon.lab.mkp.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dan Carpenter <error27@gmail.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Chuck Ebbert <cebbert@redhat.com>,
	linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	kernel-janitors@vger.kernel.org
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-vx0-f174.google.com ([209.85.220.174]:38161 "EHLO
	mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755013Ab1DEUfW (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 5 Apr 2011 16:35:22 -0400
Content-Disposition: inline
In-Reply-To: <yq1ljbi8i1z.fsf@sermon.lab.mkp.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi,

On 2010-05-17, Martin K. Petersen wrote:

> The change is obviously functionally correct.  But I object to the
> notion of hw_sectors.  The 1:1 mapping of DIF tuples and logical blocks
> is even going away in SBC3.  So let's not perpetuate that.
>
> I have a patch in my queue that gets rid of all the hw_sector references
> in the integrity code.  I'll make sure to include your fix.
>
> So thanks for spotting this.  I obviously haven't tested PI drives with
> a 4KB logical block size in combination with device mapper...

I'm just curious: did anything come of this?  Nowadays gcc 4.6 warns
about the same unused nr_sector var smatch warned about, so new
readers are coming to the same question of why this function doesn't
use hardware sectors.