From: Christoph Hellwig <hch@infradead.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Use mmap for working with disk image V2
Date: Mon, 11 Apr 2011 14:41:02 -0400 [thread overview]
Message-ID: <20110411184102.GA5755@infradead.org> (raw)
In-Reply-To: <1302351248-4853-1-git-send-email-levinsasha928@gmail.com>
How do you plan to handle I/O errors or ENOSPC conditions? Note that
shared writeable mappings are by far the feature in the VM/FS code
that is most error prone, including the impossiblity of doing sensible
error handling.
The version that accidentally used MAP_PRIVATE actually makes a lot of
sense for an equivalent of qemu's snapshot mode where the image is
readonly and changes are kept private as long as the amount of modified
blocks is small enough to not kill the host VM, but using shared
writeable mappings just sems dangerous.
next parent reply other threads:[~2011-04-11 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1302351248-4853-1-git-send-email-levinsasha928@gmail.com>
2011-04-11 18:41 ` Christoph Hellwig [this message]
2011-04-11 18:49 ` [PATCH] kvm tools: Use mmap for working with disk image V2 Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411184102.GA5755@infradead.org \
--to=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).