* Re: [PATCH] kvm tools: Use mmap for working with disk image V2
[not found] <1302351248-4853-1-git-send-email-levinsasha928@gmail.com>
@ 2011-04-11 18:41 ` Christoph Hellwig
2011-04-11 18:49 ` Pekka Enberg
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2011-04-11 18:41 UTC (permalink / raw)
To: Sasha Levin; +Cc: penberg, kvm, linux-fsdevel
How do you plan to handle I/O errors or ENOSPC conditions? Note that
shared writeable mappings are by far the feature in the VM/FS code
that is most error prone, including the impossiblity of doing sensible
error handling.
The version that accidentally used MAP_PRIVATE actually makes a lot of
sense for an equivalent of qemu's snapshot mode where the image is
readonly and changes are kept private as long as the amount of modified
blocks is small enough to not kill the host VM, but using shared
writeable mappings just sems dangerous.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm tools: Use mmap for working with disk image V2
2011-04-11 18:41 ` [PATCH] kvm tools: Use mmap for working with disk image V2 Christoph Hellwig
@ 2011-04-11 18:49 ` Pekka Enberg
0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2011-04-11 18:49 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Sasha Levin, kvm, linux-fsdevel, Ingo Molnar, Asias He,
Cyrill Gorcunov
On Mon, Apr 11, 2011 at 9:41 PM, Christoph Hellwig <hch@infradead.org> wrote:
> How do you plan to handle I/O errors or ENOSPC conditions? Note that
> shared writeable mappings are by far the feature in the VM/FS code
> that is most error prone, including the impossiblity of doing sensible
> error handling.
Good point. I reverted the commit. Thanks!
On Mon, Apr 11, 2011 at 9:41 PM, Christoph Hellwig <hch@infradead.org> wrote:
> The version that accidentally used MAP_PRIVATE actually makes a lot of
> sense for an equivalent of qemu's snapshot mode where the image is
> readonly and changes are kept private as long as the amount of modified
> blocks is small enough to not kill the host VM, but using shared
> writeable mappings just sems dangerous.
Yup, Sasha, mind submitting a MAP_PRIVATE version that's enabled with
'--snapshot' (or equivalent) command line option.
Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-11 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1302351248-4853-1-git-send-email-levinsasha928@gmail.com>
2011-04-11 18:41 ` [PATCH] kvm tools: Use mmap for working with disk image V2 Christoph Hellwig
2011-04-11 18:49 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).