linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* shrinking set of cifs fixes to merge for 2.6.39 to small set
@ 2011-04-12  1:33 Steve French
  2011-04-12 11:51 ` Jeff Layton
  0 siblings, 1 reply; 4+ messages in thread
From: Steve French @ 2011-04-12  1:33 UTC (permalink / raw)
  To: linux-cifs-u79uwXL29TY76Z2rM5mHXA; +Cc: linux-fsdevel

Since it is already past the merge window (was waiting to discuss some
fixes with others at the fs summit last week before merge),  I shrunk
the list of cifs patches waiting for merge (in cifs-2.6.git) to a much
smaller set of more critical ones. See below. (I moved the others
temporarily to a for-2.6.40 branch in cifs-2.6.git).  We (Jeff,
Shirish, I etc.) need to build/test more with this set before sending
though.

Jeff Layton (8):
      cifs: check for private_data before trying to put it
      cifs: replace /proc/fs/cifs/Experimental with a module parm
      cifs: always do is_path_accessible check in cifs_mount
      cifs: fix broken BCC check in is_valid_oplock_break
      cifs: set ra_pages in backing_dev_info
      cifs: clean up length checks in check2ndT2
      cifs: clean up various nits in unicode routines (try #2)
      cifs: wrap received signature check in srv_mutex

Steve French (6):
      Allow user names longer than 32 bytes
      Max share size is too small
      Elminate sparse __CHECK_ENDIAN__ warnings on port conversion
      various endian fixes to cifs
      [CIFS] cifs: clarify the meaning of tcpStatus == CifsGood
      [CIFS] Warn on requesting default security (ntlm) on mount





-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: shrinking set of cifs fixes to merge for 2.6.39 to small set
  2011-04-12  1:33 shrinking set of cifs fixes to merge for 2.6.39 to small set Steve French
@ 2011-04-12 11:51 ` Jeff Layton
       [not found]   ` <20110412075144.53180566-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2011-04-12 11:51 UTC (permalink / raw)
  To: Steve French; +Cc: linux-cifs, linux-fsdevel

On Mon, 11 Apr 2011 20:33:42 -0500
Steve French <smfrench@gmail.com> wrote:

> Since it is already past the merge window (was waiting to discuss some
> fixes with others at the fs summit last week before merge),  I shrunk
> the list of cifs patches waiting for merge (in cifs-2.6.git) to a much
> smaller set of more critical ones. See below. (I moved the others
> temporarily to a for-2.6.40 branch in cifs-2.6.git).  We (Jeff,
> Shirish, I etc.) need to build/test more with this set before sending
> though.
> 
> Jeff Layton (8):
>       cifs: check for private_data before trying to put it
>       cifs: replace /proc/fs/cifs/Experimental with a module parm

	I think we should also put in the patch that adds the
	page_mkwrite handler. Otherwise, we'll be adding an interface
	(new module parm) that we're just going to rip out later.

>       cifs: always do is_path_accessible check in cifs_mount
>       cifs: fix broken BCC check in is_valid_oplock_break
>       cifs: set ra_pages in backing_dev_info
>       cifs: clean up length checks in check2ndT2
>       cifs: clean up various nits in unicode routines (try #2)
>       cifs: wrap received signature check in srv_mutex
> 
> Steve French (6):
>       Allow user names longer than 32 bytes
>       Max share size is too small
>       Elminate sparse __CHECK_ENDIAN__ warnings on port conversion
>       various endian fixes to cifs
>       [CIFS] cifs: clarify the meaning of tcpStatus == CifsGood
>       [CIFS] Warn on requesting default security (ntlm) on mount
> 
> 

Other than that, this looks like a reasonable set. I'll plan to build
it later today and give it some testing.

-- 
Jeff Layton <jlayton@redhat.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: shrinking set of cifs fixes to merge for 2.6.39 to small set
       [not found]   ` <20110412075144.53180566-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
@ 2011-04-12 12:30     ` Steve French
       [not found]       ` <BANLkTin627FFHH_mt1Lu7TMVMAb5y-DKgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Steve French @ 2011-04-12 12:30 UTC (permalink / raw)
  To: Jeff Layton; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel

On Tue, Apr 12, 2011 at 6:51 AM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On Mon, 11 Apr 2011 20:33:42 -0500
> Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> Since it is already past the merge window (was waiting to discuss some
>> fixes with others at the fs summit last week before merge),  I shrunk
>> the list of cifs patches waiting for merge (in cifs-2.6.git) to a much
>> smaller set of more critical ones. See below. (I moved the others
>> temporarily to a for-2.6.40 branch in cifs-2.6.git).  We (Jeff,
>> Shirish, I etc.) need to build/test more with this set before sending
>> though.
>>
>> Jeff Layton (8):
>>       cifs: check for private_data before trying to put it
>>       cifs: replace /proc/fs/cifs/Experimental with a module parm
>
>        I think we should also put in the patch that adds the
>        page_mkwrite handler.

I agree but it had more merge conflicts.

>
> Other than that, this looks like a reasonable set. I'll plan to build
> it later today and give it some testing.
>
> --
> Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>



-- 
Thanks,

Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: shrinking set of cifs fixes to merge for 2.6.39 to small set
       [not found]       ` <BANLkTin627FFHH_mt1Lu7TMVMAb5y-DKgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2011-04-12 13:16         ` Jeff Layton
  0 siblings, 0 replies; 4+ messages in thread
From: Jeff Layton @ 2011-04-12 13:16 UTC (permalink / raw)
  To: Steve French; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel

On Tue, 12 Apr 2011 07:30:14 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Tue, Apr 12, 2011 at 6:51 AM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > On Mon, 11 Apr 2011 20:33:42 -0500
> > Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> >> Since it is already past the merge window (was waiting to discuss some
> >> fixes with others at the fs summit last week before merge),  I shrunk
> >> the list of cifs patches waiting for merge (in cifs-2.6.git) to a much
> >> smaller set of more critical ones. See below. (I moved the others
> >> temporarily to a for-2.6.40 branch in cifs-2.6.git).  We (Jeff,
> >> Shirish, I etc.) need to build/test more with this set before sending
> >> though.
> >>
> >> Jeff Layton (8):
> >>       cifs: check for private_data before trying to put it
> >>       cifs: replace /proc/fs/cifs/Experimental with a module parm
> >
> >        I think we should also put in the patch that adds the
> >        page_mkwrite handler.
> 
> I agree but it had more merge conflicts.
> 

Ok, I just resent the patch with the merge conflicts fixed.

I've also given the set you're proposing + the page_mkwrite patch a
quick smoke test run with connectathon and it seems to be ok.

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-04-12 13:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-12  1:33 shrinking set of cifs fixes to merge for 2.6.39 to small set Steve French
2011-04-12 11:51 ` Jeff Layton
     [not found]   ` <20110412075144.53180566-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-04-12 12:30     ` Steve French
     [not found]       ` <BANLkTin627FFHH_mt1Lu7TMVMAb5y-DKgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-12 13:16         ` Jeff Layton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).