From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 1/4] writeback: add bdi_dirty_limit() kernel-doc Date: Wed, 13 Apr 2011 23:47:51 +0200 Message-ID: <20110413214751.GC4648@quack.suse.cz> References: <20110413085937.981293444@intel.com> <20110413090415.389888354@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Peter Zijlstra , Jan Kara , Dave Chinner , Hugh Dickins , Rik van Riel , LKML , Linux Memory Management List , linux-fsdevel@vger.kernel.org To: Wu Fengguang Return-path: Content-Disposition: inline In-Reply-To: <20110413090415.389888354@intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed 13-04-11 16:59:38, Wu Fengguang wrote: > Clarify the bdi_dirty_limit() comment. > > Signed-off-by: Wu Fengguang Looks fine. Acked-by: Jan Kara Honza > --- > mm/page-writeback.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > --- linux-next.orig/mm/page-writeback.c 2011-03-03 14:38:12.000000000 +0800 > +++ linux-next/mm/page-writeback.c 2011-03-03 14:40:52.000000000 +0800 > @@ -437,10 +437,17 @@ void global_dirty_limits(unsigned long * > *pdirty = dirty; > } > > -/* > +/** > * bdi_dirty_limit - @bdi's share of dirty throttling threshold > + * @bdi: the backing_dev_info to query > + * @dirty: global dirty limit in pages > + * > + * Returns @bdi's dirty limit in pages. The term "dirty" in the context of > + * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. > + * And the "limit" in the name is not seriously taken as hard limit in > + * balance_dirty_pages(). > * > - * Allocate high/low dirty limits to fast/slow devices, in order to prevent > + * It allocates high/low dirty limits to fast/slow devices, in order to prevent > * - starving fast devices > * - piling up dirty pages (that will take long time to sync) on slow devices > * > > -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org