From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 00/12] IO-less dirty throttling v7 Date: Sun, 17 Apr 2011 12:10:03 +0800 Message-ID: <20110417041003.GA17032@localhost> References: <20110416132546.765212221@intel.com> <20110417014430.GA9419@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , Jan Kara , Christoph Hellwig , Trond Myklebust , Dave Chinner , Theodore Ts'o , Chris Mason , Peter Zijlstra , Mel Gorman , Rik van Riel , KOSAKI Motohiro , Greg Thelen , Minchan Kim , Vivek Goyal , Andrea Righi , Balbir Singh , linux-mm , "linux-fsdevel@vger.kernel.org" , LKML To: "sedat.dilek@gmail.com" Return-path: Received: from mga03.intel.com ([143.182.124.21]:25129 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648Ab1DQEKN (ORCPT ); Sun, 17 Apr 2011 00:10:13 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Apr 17, 2011 at 11:18:43AM +0800, Sedat Dilek wrote: > On Sun, Apr 17, 2011 at 3:44 AM, Wu Fengguang wrote: > > Hi Sedat, > > > > On Sun, Apr 17, 2011 at 12:27:58AM +0800, Sedat Dilek wrote: > > > >> I pulled your tree into linux-next (next-20110415) on an i386 Debi= an host. > >> > >> My build breaks here: > >> ... > >> =C2=A0 MODPOST vmlinux.o > >> =C2=A0 GEN =C2=A0 =C2=A0 .version > >> =C2=A0 CHK =C2=A0 =C2=A0 include/generated/compile.h > >> =C2=A0 UPD =C2=A0 =C2=A0 include/generated/compile.h > >> =C2=A0 CC =C2=A0 =C2=A0 =C2=A0init/version.o > >> =C2=A0 LD =C2=A0 =C2=A0 =C2=A0init/built-in.o > >> =C2=A0 LD =C2=A0 =C2=A0 =C2=A0.tmp_vmlinux1 > >> mm/built-in.o: In function `bdi_position_ratio': > >> page-writeback.c:(.text+0x5c83): undefined reference to `__udivdi3= ' > > > > Yes it can be fixed by the attached patch. > > > >> mm/built-in.o: In function `calc_period_shift.part.10': > >> page-writeback.c:(.text+0x6446): undefined reference to `____ilog2= _NaN' > > > > I cannot reproduce this error. In the git tree, calc_period_shift()= is > > actually quite simple: > > > > static int calc_period_shift(void) > > { > > =C2=A0 =C2=A0 =C2=A0 =C2=A0return 2 + ilog2(default_backing_dev_inf= o.avg_write_bandwidth); > > } > > > > where avg_write_bandwidth is of type "unsigned long". > > > >> make[4]: *** [.tmp_vmlinux1] Error > >> > >> BTW, which kernel-config options have to be set besides > >> CONFIG_BLK_DEV_THROTTLING=3Dy? > > > > No. I used your kconfig on 2.6.39-rc3 and it compiles OK for i386. > > > > I've pushed two patches into the git tree fixing the compile errors= =2E > > Thank you for trying it out and report! > > > > Thanks, > > Fengguang > > >=20 > Thanks for your patch. >=20 > The 1st part of the build-error is gone, but 2nd part still remains: >=20 > LD .tmp_vmlinux1 > mm/built-in.o: In function `calc_period_shift.part.10': > page-writeback.c:(.text+0x6458): undefined reference to `____ilog2_Na= N' > make[4]: *** [.tmp_vmlinux1] Error 1 >=20 > I have attached some disasm-ed files. OK. I tried next-20110415 and your kconfig and still got no error. Please revert the last commit. It's not necessary anyway. commit 84a9890ddef487d9c6d70934c0a2addc65923bcf Author: Wu Fengguang Date: Sat Apr 16 18:38:41 2011 -0600 writeback: scale dirty proportions period with writeout bandwidth =20 CC: Peter Zijlstra Signed-off-by: Wu Fengguang > Unfortunately, I don't see any new commits in your GIT tree. Yeah I cannot see it in the web interface, too: http://git.kernel.org/?p=3Dlinux/kernel/git/wfg/writeback.git;a=3Dshort= log;h=3Drefs/heads/dirty-throttling-v7 But they are in the dirty-throttling-v7 branch at kernel.org: commit d0e30163e390d87387ec13e3b1c2168238c26793 Author: Wu Fengguang Date: Sun Apr 17 11:59:12 2011 +0800 Revert "writeback: scale dirty proportions period with writeout ban= dwidth" =20 This reverts commit 84a9890ddef487d9c6d70934c0a2addc65923bcf. =20 sedat.dilek@gmail.com: =20 LD .tmp_vmlinux1 mm/built-in.o: In function `calc_period_shift.part.10': page-writeback.c:(.text+0x6458): undefined reference to `____ilog= 2_NaN' make[4]: *** [.tmp_vmlinux1] Error 1 commit fc5c8b04119a5bcc46865e66eec3e6133ecb56e9 Author: Wu Fengguang Date: Sun Apr 17 09:22:41 2011 -0600 writeback: quick CONFIG_BLK_DEV_THROTTLING=3Dn compile fix =20 Reported-by: Sedat Dilek Signed-off-by: Wu Fengguang commit c4a7e3f48dcfae71d0e3d2c55dcc381b3def1919 Author: Wu Fengguang Date: Sun Apr 17 09:04:44 2011 -0600 writeback: i386 compile fix =20 mm/built-in.o: In function `bdi_position_ratio': page-writeback.c:(.text+0x5c83): undefined reference to `__udivdi3' mm/built-in.o: In function `calc_period_shift.part.10': page-writeback.c:(.text+0x6446): undefined reference to `____ilog2_= NaN' make[4]: *** [.tmp_vmlinux1] Error =20 Reported-by: Sedat Dilek Signed-off-by: Wu Fengguang Thanks, =46engguang -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html