From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 6/6] NFS: return -EAGAIN when skipped commit in nfs_commit_unstable_pages() Date: Thu, 21 Apr 2011 00:40:08 -0400 Message-ID: <20110421044008.GD22423@infradead.org> References: <20110419030003.108796967@intel.com> <20110419030532.902141228@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Jan Kara , Mel Gorman , Trond Myklebust , Dave Chinner , Itaru Kitayama , Minchan Kim , LKML , linux-fsdevel@vger.kernel.org, Linux Memory Management List To: Wu Fengguang Return-path: Content-Disposition: inline In-Reply-To: <20110419030532.902141228@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Apr 19, 2011 at 11:00:09AM +0800, Wu Fengguang wrote: > It's probably not sane to return success while redirtying the inode at > the same time in ->write_inode(). It is not, as it really confuses the writeback code.