From: Jordi Pujol <jordipujolp@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: overlayfs v8 problems with whiteout links
Date: Wed, 27 Apr 2011 09:57:19 +0200 [thread overview]
Message-ID: <201104270957.19356.jordipujolp@gmail.com> (raw)
In-Reply-To: <87k4ehm2ox.fsf@tucsk.pomaz.szeredi.hu>
[-- Attachment #1: Type: Text/Plain, Size: 864 bytes --]
A Dimarts 26 Abril 2011 17:50:54, Miklos Szeredi va escriure:
> It doesn't look like the correct fix, however. Even though
> ovl_dentry_lower() returns NULL, the lower file should normally exist.
it solves the problem, but we should investigate why,
>
> Please look a the ovl_do_lookup() logic: if oe->opaque is set to true,
> then oe->lowerdentry will be set to NULL, even when the lower dentry
> does actually exist.
>
> So your patch might cover up the problem that you've been observing
> (because it won't create the whiteouts in some cases), but it will
> introduce another bug.
>
Agree, the working line in this patch is checking for ovl_dentry_lower in
ovl_do_remove, the other lines are part of the test; should not be used.
another patch is attached,
Thanks,
Jordi Pujol
Live never ending Tale
GNU/Linux Live forever!
http://livenet.selfip.com
[-- Attachment #2: 09-bug-remove-lower-dentry.patch --]
[-- Type: text/x-patch, Size: 366 bytes --]
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -376,7 +383,8 @@ static int ovl_do_remove(struct dentry *
ovl_dentry_version_inc(dentry->d_parent);
}
- if (type != OVL_PATH_UPPER || ovl_dentry_is_opaque(dentry))
+ if ((type != OVL_PATH_UPPER || ovl_dentry_is_opaque(dentry))
+ && ovl_dentry_lower(dentry))
err = ovl_whiteout(upperdir, dentry);
/*
next prev parent reply other threads:[~2011-04-27 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 8:43 overlayfs v8 problems with whiteout links Jordi Pujol
2011-04-23 12:43 ` Jordi Pujol
2011-04-23 14:51 ` Jordi Pujol
2011-04-24 18:08 ` Jordi Pujol
2011-04-26 15:50 ` Miklos Szeredi
2011-04-27 7:57 ` Jordi Pujol [this message]
2011-04-27 11:41 ` Miklos Szeredi
2011-04-27 13:30 ` Jordi Pujol
2011-04-27 14:50 ` Jordi Pujol
2011-04-27 18:52 ` Miklos Szeredi
2011-04-26 15:34 ` Miklos Szeredi
2011-04-27 9:36 ` Jordi Pujol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104270957.19356.jordipujolp@gmail.com \
--to=jordipujolp@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).