From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 1/6] writeback: pass writeback_control down to move_expired_inodes() Date: Wed, 4 May 2011 19:13:10 +0800 Message-ID: <20110504111310.GB5191@localhost> References: <20110420080336.441157866@intel.com> <20110420080917.759855316@intel.com> <20110504110430.GA4646@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Jan Kara , Mel Gorman , Mel Gorman , Dave Chinner , Itaru Kitayama , Minchan Kim , Linux Memory Management List , "linux-fsdevel@vger.kernel.org" , LKML To: Christoph Hellwig Return-path: Content-Disposition: inline In-Reply-To: <20110504110430.GA4646@infradead.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, May 04, 2011 at 07:04:32PM +0800, Christoph Hellwig wrote: > On Wed, Apr 20, 2011 at 04:03:37PM +0800, Wu Fengguang wrote: > > No behavior change. This will add debug visibility to the code, for > > example, to dump the wbc contents when kprobing queue_io(). > > I don't think it's a good idea. The writeback_control should move > back to just controlling per-inode writeback and not be passed to > more routines dealing with high-level writeback. Good point. I can do without this patch. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org