From: Wu Fengguang <fengguang.wu@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <david@fromorbit.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 3/3] writeback: avoid extra sync work at enqueue time
Date: Thu, 5 May 2011 20:48:47 +0800 [thread overview]
Message-ID: <20110505124847.GA5623@localhost> (raw)
In-Reply-To: <20110505124237.GB24009@lst.de>
On Thu, May 05, 2011 at 08:42:37PM +0800, Christoph Hellwig wrote:
> On Thu, May 05, 2011 at 02:41:22PM +0200, Christoph Hellwig wrote:
> > On Thu, May 05, 2011 at 08:27:32PM +0800, Wu Fengguang wrote:
> > > - wbc.wb_start = jiffies; /* livelock avoidance */
> > > + oldest_jif = jiffies;
> > > + wbc.older_than_this = &oldest_jif;
> >
> > Can't you kill the oldest_jif variable now?
>
> Err, -ENOCOFFEE. You could only kill it if you implement Jan's suggestion
> of not making older_than_this a pointer..
Yes. And that won't be a straightforward code refactor. It will have
very small side effects, so we'd better kill it in a standalone patch.
Thanks,
Fengguang
next prev parent reply other threads:[~2011-05-05 12:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 3:17 [PATCH 0/3] sync livelock fixes v2 Wu Fengguang
2011-05-02 3:17 ` [PATCH 1/3] writeback: introduce wbc.tagged_sync for the WB_SYNC_NONE sync stage Wu Fengguang
2011-05-04 21:00 ` Jan Kara
2011-05-05 12:14 ` Wu Fengguang
2011-05-05 13:55 ` Jan Kara
2011-05-05 14:06 ` Wu Fengguang
2011-05-02 3:17 ` [PATCH 2/3] writeback: update dirtied_when for synced inode to prevent livelock Wu Fengguang
2011-05-04 21:10 ` Jan Kara
2011-05-05 12:18 ` Wu Fengguang
2011-05-02 3:17 ` [PATCH 3/3] writeback: avoid extra sync work at enqueue time Wu Fengguang
2011-05-04 21:24 ` Jan Kara
2011-05-05 12:27 ` Wu Fengguang
2011-05-05 12:41 ` Christoph Hellwig
2011-05-05 12:42 ` Christoph Hellwig
2011-05-05 12:48 ` Wu Fengguang [this message]
2011-05-05 14:01 ` Jan Kara
2011-05-05 14:10 ` Wu Fengguang
2011-05-05 14:13 ` Wu Fengguang
2011-05-05 14:34 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2011-04-30 22:36 [PATCH 0/3] sync livelock fixes Wu Fengguang
2011-04-30 22:36 ` [PATCH 3/3] writeback: avoid extra sync work at enqueue time Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505124847.GA5623@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox