From: Christoph Hellwig <hch@infradead.org>
To: Josef Bacik <josef@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH] fs: kill default_llseek
Date: Mon, 9 May 2011 10:06:14 -0400 [thread overview]
Message-ID: <20110509140614.GB7669@infradead.org> (raw)
In-Reply-To: <4DC7EAD7.9070606@redhat.com>
On Mon, May 09, 2011 at 09:23:35AM -0400, Josef Bacik wrote:
> So every sb has s_maxbytes set to something, is this not acceptable
> for character devices? I guess some can let you seek well past this
> point so we should just do some if (S_ISCHR()) return or whatever?
Probably for all special files just to be sure, although
pipes/sockets/fifos aren't searchable, and block devices tend to
get redirected to their own superblock.
prev parent reply other threads:[~2011-05-09 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 14:27 [PATCH] fs: kill default_llseek Josef Bacik
2011-05-08 14:23 ` Arnd Bergmann
2011-05-09 13:23 ` Josef Bacik
2011-05-09 14:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509140614.GB7669@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).