From: Christoph Hellwig <hch@infradead.org>
To: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 10/14] HPFS: Implement fsync for hpfs
Date: Tue, 10 May 2011 04:03:49 -0400 [thread overview]
Message-ID: <20110510080349.GC13420@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1105082029340.7013@artax.karlin.mff.cuni.cz>
On Sun, May 08, 2011 at 08:44:19PM +0200, Mikulas Patocka wrote:
> Index: linux-2.6.39-rc5-fast/fs/hpfs/file.c
> ===================================================================
> --- linux-2.6.39-rc5-fast.orig/fs/hpfs/file.c 2011-05-05 01:02:43.000000000 +0200
> +++ linux-2.6.39-rc5-fast/fs/hpfs/file.c 2011-05-05 01:02:56.000000000 +0200
> @@ -20,8 +20,8 @@ static int hpfs_file_release(struct inod
>
> int hpfs_file_fsync(struct file *file, int datasync)
> {
> - /*return file_fsync(file, datasync);*/
> - return 0; /* Don't fsync :-) */
> + struct inode *inode = file->f_mapping->host;
> + return sync_blockdev(inode->i_sb->s_bdev);
So you push all dirty data into buffers immediately and don't have
anything else to write back?
next prev parent reply other threads:[~2011-05-10 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 18:44 [PATCH 10/14] HPFS: Implement fsync for hpfs Mikulas Patocka
2011-05-10 8:03 ` Christoph Hellwig [this message]
2011-05-11 13:03 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510080349.GC13420@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).