From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 10/14] HPFS: Implement fsync for hpfs Date: Tue, 10 May 2011 04:03:49 -0400 Message-ID: <20110510080349.GC13420@infradead.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Mikulas Patocka Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, May 08, 2011 at 08:44:19PM +0200, Mikulas Patocka wrote: > Index: linux-2.6.39-rc5-fast/fs/hpfs/file.c > =================================================================== > --- linux-2.6.39-rc5-fast.orig/fs/hpfs/file.c 2011-05-05 01:02:43.000000000 +0200 > +++ linux-2.6.39-rc5-fast/fs/hpfs/file.c 2011-05-05 01:02:56.000000000 +0200 > @@ -20,8 +20,8 @@ static int hpfs_file_release(struct inod > > int hpfs_file_fsync(struct file *file, int datasync) > { > - /*return file_fsync(file, datasync);*/ > - return 0; /* Don't fsync :-) */ > + struct inode *inode = file->f_mapping->host; > + return sync_blockdev(inode->i_sb->s_bdev); So you push all dirty data into buffers immediately and don't have anything else to write back?