From: Joel Becker <jlbec@evilplan.org>
To: Sage Weil <sage@newdream.net>
Cc: viro@ZenIV.linux.org.uk, hch@lst.de,
linux-fsdevel@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 16/18] ocfs2: remove unnecessary dentry_unhash on rmdir/rename_dir
Date: Tue, 10 May 2011 13:24:21 -0700 [thread overview]
Message-ID: <20110510202420.GA29657@noexit.corp.google.com> (raw)
In-Reply-To: <1305002616-16782-17-git-send-email-sage@newdream.net>
On Mon, May 09, 2011 at 09:43:34PM -0700, Sage Weil wrote:
> Ocfs2 has no issues with lingering references to unlinked directory inodes.
>
> CC: Mark Fasheh <mfasheh@suse.com>
> CC: Joel Becker <jlbec@evilplan.org>
> CC: ocfs2-devel@oss.oracle.com
> Signed-off-by: Sage Weil <sage@newdream.net>
> ---
> fs/ocfs2/namei.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index f3582a6..e5d738c 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -810,9 +810,6 @@ static int ocfs2_unlink(struct inode *dir,
> (unsigned long long)OCFS2_I(dir)->ip_blkno,
> (unsigned long long)OCFS2_I(inode)->ip_blkno);
>
> - if (S_ISDIR(inode->i_mode))
> - dentry_unhash(dentry);
> -
I'm wary about this. If ocfs2_unlink/ocfs2_rename fail,
d_delete is not called. Also, d_delete doesn't always clear it. I
worry that we'll have a dentry that can be traversed even though its
state in the cluster is bad or unknown.
However, I think our d_revalidate checks should correctly catch
these cases. If we get to the point of doing actual work, we've
assuredly told other nodes to forget about this directory. So I'll
tentatively Ack this, and hope it doesn't explode ;-)
Acked-by: Joel Becker <jlbec@evilplan.org>
--
"I inject pure kryptonite into my brain.
It improves my kung fu, and it eases the pain."
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2011-05-10 20:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 4:43 [PATCH 00/18] clean up VFS dentry_hash (mis)behavior Sage Weil
2011-05-10 4:43 ` [PATCH 01/18] vfs: dentry_unhash immediately prior to rmdir Sage Weil
2011-05-10 8:12 ` Christoph Hellwig
2011-05-10 4:43 ` [PATCH 02/18] vfs: remove dget() from dentry_unhash() Sage Weil
2011-05-10 4:43 ` [PATCH 03/18] vfs: push dentry_unhash on rmdir into file systems Sage Weil
2011-05-10 4:43 ` [PATCH 04/18] vfs: push dentry_unhash on rename_dir " Sage Weil
2011-05-10 4:43 ` [PATCH 05/18] vfs: update dentry_unhash() comment Sage Weil
2011-05-10 4:43 ` [PATCH 06/18] libfs: drop unneeded dentry_unhash Sage Weil
2011-05-10 4:43 ` [PATCH 07/18] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems Sage Weil
2011-05-10 4:43 ` [PATCH 08/18] ceph: remove unnecessary dentry_unhash calls Sage Weil
2011-05-10 4:43 ` [PATCH 09/18] xfs: remove unnecessary dentry_unhash from rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 10/18] btrfs: remove unnecessary dentry_unhash in rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 11/18] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 12/18] ext3: " Sage Weil
2011-05-10 4:43 ` [PATCH 13/18] ext2: " Sage Weil
[not found] ` <1305002616-16782-1-git-send-email-sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org>
2011-05-10 4:43 ` [PATCH 14/18] nfs: " Sage Weil
2011-05-10 4:43 ` [PATCH 15/18] exofs: " Sage Weil
2011-05-11 12:53 ` Boaz Harrosh
2011-05-10 4:43 ` [PATCH 16/18] ocfs2: " Sage Weil
2011-05-10 20:24 ` Joel Becker [this message]
2011-05-10 4:43 ` [PATCH 17/18] gfs2: " Sage Weil
2011-05-10 8:45 ` Steven Whitehouse
2011-05-10 15:47 ` Sage Weil
2011-05-10 4:43 ` [PATCH 18/18] cifs: " Sage Weil
2011-05-11 10:06 ` [PATCH 00/18] clean up VFS dentry_hash (mis)behavior Christoph Hellwig
2011-05-11 17:18 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510202420.GA29657@noexit.corp.google.com \
--to=jlbec@evilplan.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).