From: Al Viro <viro@ZenIV.linux.org.uk>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
adilger@dilger.ca, hch@lst.de
Subject: Re: [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags V2
Date: Sun, 22 May 2011 03:11:30 +0100 [thread overview]
Message-ID: <20110522021130.GI19987@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1305913471-3150-1-git-send-email-josef@redhat.com>
On Fri, May 20, 2011 at 01:44:30PM -0400, Josef Bacik wrote:
> + if (unlikely(d_need_lookup(dentry))) {
> + if (nameidata_dentry_drop_rcu(nd, dentry))
> + return -ECHILD;
> + dput(dentry);
> + dentry = NULL;
> + goto retry;
Yecchhh... How about simple goto unlazy; here instead and doing the rest
there? Especially since you have the same kind of thing elsewhere in the
same sucker. It had been bloody painful to untangle that thing; let's not
add to the rat's nest that still remains...
next prev parent reply other threads:[~2011-05-22 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 17:44 [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags V2 Josef Bacik
2011-05-20 17:44 ` [PATCH 2/2] Btrfs: load the key from the dir item in readdir into a fake dentry V2 Josef Bacik
2011-05-22 2:11 ` Al Viro [this message]
2011-05-23 16:13 ` [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags V2 Josef Bacik
2011-05-26 10:35 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110522021130.GI19987@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=adilger@dilger.ca \
--cc=hch@lst.de \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).