From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthew Wilcox <matthew@wil.cx>
Subject: Re: Semaphore should be released in get_super
Date: Tue, 24 May 2011 05:20:07 -0600
Message-ID: <20110524112007.GD26392@parisc-linux.org>
References: <4DDB8317.7040300@onet.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: sdrb <sdrb@onet.eu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from palinux.external.hp.com ([192.25.206.14]:58329 "EHLO
	mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753774Ab1EXLUJ (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 24 May 2011 07:20:09 -0400
Content-Disposition: inline
In-Reply-To: <4DDB8317.7040300@onet.eu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, May 24, 2011 at 12:06:15PM +0200, sdrb wrote:
> Hello,
>
> Probably I found a bug in get_super() proc. I think there should be  
> semaphore released before return sb.

That's the point of get_super().  It's supposed to return with the
semaphore held.  Users call drop_super() later which releases the
semaphore.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."