From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: OOPS in configfs when doing d_delete Date: Fri, 27 May 2011 14:13:49 -0700 Message-ID: <20110527211349.GB30232@noexit.corp.google.com> References: <4D623C62.8030509@suse.cz> <20110221104359.GA18538@noexit> <4D6242AD.2090600@suse.cz> <20110222091415.GD30966@noexit> <4DCBA9A5.9040306@gmail.com> <20110518195842.GB5898@noexit.corp.google.com> <4DE013B6.9070801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Slaby , npiggin@kernel.dk, Al Viro , linux-fsdevel@vger.kernel.org, LKML To: Jiri Slaby Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:55391 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754125Ab1E0VNz (ORCPT ); Fri, 27 May 2011 17:13:55 -0400 Content-Disposition: inline In-Reply-To: <4DE013B6.9070801@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 27, 2011 at 11:12:22PM +0200, Jiri Slaby wrote: > On 05/18/2011 09:58 PM, Joel Becker wrote: > > On Thu, May 12, 2011 at 11:34:29AM +0200, Jiri Slaby wrote: > >> On 02/22/2011 10:14 AM, Joel Becker wrote: > >>> On Mon, Feb 21, 2011 at 11:47:09AM +0100, Jiri Slaby wrote: > >>>>> I think you're right about the superfluous test, but I need more > >>>>> investigation to see what's going on. Thanks for the report. > >>>>> What was causing attach_group() to fail? Do you know? > >>>> > >>>> Dunno, I just modprobe'd the configfs example from Doc dir > >>>> (configfs_example_macros). > >>> > >>> I'm going to revisit the failed example (which shouldn't fail, I > >>> would think). Can you try the following patch to safely handle the > >>> failure rather than crashing the kernel? > >>> > >>> Joel > >> > >> Hi, what's the status of this? (It's verified to work some time ago.) > > > > The runtime fix is queued up for mainline. I'll be looking at > > the example code fix for the next merge window. > > The fixes for the examples were merged today after being some time in > the -mm tree. I saw. Thanks. Joel -- One look at the From: understanding has blossomed .procmailrc grows - Alexander Viro http://www.jlbec.org/ jlbec@evilplan.org