From: Jan Kara <jack@suse.cz>
To: Sage Weil <sage@newdream.net>
Cc: hch@infradead.org, viro@ZenIV.linux.org.uk,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 10/26] udf: remove unnecessary dentry_unhash from rmdir, dir rename
Date: Mon, 30 May 2011 11:43:39 +0200 [thread overview]
Message-ID: <20110530094339.GA4075@quack.suse.cz> (raw)
In-Reply-To: <1306528939-30636-11-git-send-email-sage@newdream.net>
On Fri 27-05-11 13:42:03, Sage Weil wrote:
> udf does not have problems with references to unlinked directories.
Acked-by: Jan Kara <jack@suse.cz>
> CC: Jan Kara <jack@suse.cz>
> Signed-off-by: Sage Weil <sage@newdream.net>
> ---
> fs/udf/namei.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/udf/namei.c b/fs/udf/namei.c
> index 4d76594..f1dce84 100644
> --- a/fs/udf/namei.c
> +++ b/fs/udf/namei.c
> @@ -783,8 +783,6 @@ static int udf_rmdir(struct inode *dir, struct dentry *dentry)
> struct fileIdentDesc *fi, cfi;
> struct kernel_lb_addr tloc;
>
> - dentry_unhash(dentry);
> -
> retval = -ENOENT;
> fi = udf_find_entry(dir, &dentry->d_name, &fibh, &cfi);
> if (!fi)
> @@ -1083,9 +1081,6 @@ static int udf_rename(struct inode *old_dir, struct dentry *old_dentry,
> struct kernel_lb_addr tloc;
> struct udf_inode_info *old_iinfo = UDF_I(old_inode);
>
> - if (new_inode && S_ISDIR(new_inode->i_mode))
> - dentry_unhash(new_dentry);
> -
> ofi = udf_find_entry(old_dir, &old_dentry->d_name, &ofibh, &ocfi);
> if (ofi) {
> if (ofibh.sbh != ofibh.ebh)
> --
> 1.7.0
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-05-30 9:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 20:41 [PATCH 00/26] Some final dentry_unhash cleanup Sage Weil
2011-05-27 20:41 ` [PATCH 01/26] bfs: remove unnecessary dentry_unhash on dir rename Sage Weil
2011-05-27 20:41 ` [PATCH 02/26] sysv: remove unnecessary dentry_unhash from rmdir, " Sage Weil
2011-05-27 20:41 ` [PATCH 03/26] jffs2: " Sage Weil
2011-05-27 20:41 ` [PATCH 04/26] jfs: " Sage Weil
2011-05-27 20:41 ` [PATCH 05/26] logfs: " Sage Weil
[not found] ` <1306528939-30636-1-git-send-email-sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org>
2011-05-27 20:41 ` [PATCH 06/26] nilfs2: " Sage Weil
2011-05-27 20:42 ` [PATCH 07/26] ubifs: " Sage Weil
2011-05-27 20:42 ` [PATCH 08/26] ufs: " Sage Weil
2011-05-27 20:42 ` [PATCH 09/26] reiserfs: " Sage Weil
2011-05-27 20:42 ` [PATCH 10/26] udf: " Sage Weil
2011-05-30 9:43 ` Jan Kara [this message]
2011-05-27 20:42 ` [PATCH 11/26] omfs: remove unnecessary dentry_unhash on rmdir, dir rneame Sage Weil
2011-06-05 0:42 ` Bob Copeland
2011-05-27 20:42 ` [PATCH 12/26] hfs: remove unnecessary dentry_unhash on rmdir, dir rename Sage Weil
2011-05-27 20:42 ` [PATCH 13/26] hfsplus: " Sage Weil
2011-05-27 20:42 ` [PATCH 14/26] hostfs: " Sage Weil
2011-05-27 20:42 ` [PATCH 15/26] ecryptfs: " Sage Weil
2011-05-27 20:42 ` [PATCH 16/26] ncpfs: document dentry_unhash usage Sage Weil
2011-05-27 20:42 ` [PATCH 17/26] ncpfs: fix rename over directory with dangling references Sage Weil
2011-05-27 20:42 ` [PATCH 18/26] 9p: remove unnecessary dentry_unhash on rmdir, dir rename Sage Weil
2011-05-27 20:42 ` [PATCH 19/26] affs: " Sage Weil
2011-05-27 20:42 ` [PATCH 20/26] afs: " Sage Weil
2011-05-27 20:42 ` [PATCH 21/26] coda: " Sage Weil
2011-05-27 20:42 ` [PATCH 22/26] fuse: " Sage Weil
2011-05-27 20:42 ` [PATCH 23/26] minix: " Sage Weil
2011-05-27 20:42 ` [PATCH 24/26] hpfs: " Sage Weil
2011-05-27 20:42 ` [PATCH 25/26] fat: " Sage Weil
2011-05-28 6:37 ` OGAWA Hirofumi
2011-05-27 20:42 ` [PATCH 26/26] configfs: " Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530094339.GA4075@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).