From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 10/26] udf: remove unnecessary dentry_unhash from rmdir, dir rename Date: Mon, 30 May 2011 11:43:39 +0200 Message-ID: <20110530094339.GA4075@quack.suse.cz> References: <1306528939-30636-1-git-send-email-sage@newdream.net> <1306528939-30636-11-git-send-email-sage@newdream.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, Jan Kara To: Sage Weil Return-path: Received: from cantor.suse.de ([195.135.220.2]:46443 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355Ab1E3Jnl (ORCPT ); Mon, 30 May 2011 05:43:41 -0400 Content-Disposition: inline In-Reply-To: <1306528939-30636-11-git-send-email-sage@newdream.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri 27-05-11 13:42:03, Sage Weil wrote: > udf does not have problems with references to unlinked directories. Acked-by: Jan Kara > CC: Jan Kara > Signed-off-by: Sage Weil > --- > fs/udf/namei.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/fs/udf/namei.c b/fs/udf/namei.c > index 4d76594..f1dce84 100644 > --- a/fs/udf/namei.c > +++ b/fs/udf/namei.c > @@ -783,8 +783,6 @@ static int udf_rmdir(struct inode *dir, struct dentry *dentry) > struct fileIdentDesc *fi, cfi; > struct kernel_lb_addr tloc; > > - dentry_unhash(dentry); > - > retval = -ENOENT; > fi = udf_find_entry(dir, &dentry->d_name, &fibh, &cfi); > if (!fi) > @@ -1083,9 +1081,6 @@ static int udf_rename(struct inode *old_dir, struct dentry *old_dentry, > struct kernel_lb_addr tloc; > struct udf_inode_info *old_iinfo = UDF_I(old_inode); > > - if (new_inode && S_ISDIR(new_inode->i_mode)) > - dentry_unhash(new_dentry); > - > ofi = udf_find_entry(old_dir, &old_dentry->d_name, &ofibh, &ocfi); > if (ofi) { > if (ofibh.sbh != ofibh.ebh) > -- > 1.7.0 > -- Jan Kara SUSE Labs, CR