From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>, XFS <xfs@oss.sgi.com>,
Sergey Ivanov <sergey57@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] xfstests: add support for ext4dev FSTYP
Date: Wed, 1 Jun 2011 21:47:04 -0400 [thread overview]
Message-ID: <20110602014704.GA16306@thunk.org> (raw)
In-Reply-To: <4DE5C1FE.8080006@redhat.com>
On Tue, May 31, 2011 at 11:37:18PM -0500, Eric Sandeen wrote:
>
> I'm less certain of the change from fsck -t $FSTYP to fsck.$FSTYP
>
> What issue are you avoiding? wouldn't fsck -t ext4dev invoke
> fsck.ext4dev anyway?
This is a change I make locally when I've been debugging my bigalloc
code as well. There reason for that is because I want to override the
fsck.ext4 that would get used by using path hacking. The problem was
that fsck -t ext4 will look for /sbin/fsck.ext4, where as I wanted it
to use the fsck.ext4 that was first in the PATH.
So I changed "/sbin/fsck -t $FSTYP" to "fsck.$FSTYP" and made sure
/sbin was tacked onto the path.
It might be that the right answer is that fsck should have an
environment variable or some other way of controlling the search path
it uses to find the fsck.XXX binary.
- Ted
prev parent reply other threads:[~2011-06-02 1:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 3:13 [PATCH] xfstests: add support for ext4dev FSTYP Amir Goldstein
2011-06-01 4:37 ` Eric Sandeen
2011-06-01 4:56 ` Amir Goldstein
2011-06-01 5:22 ` Eric Sandeen
2011-06-01 5:34 ` Eric Sandeen
2011-06-01 6:37 ` Amir Goldstein
2011-06-01 11:48 ` sergey ivanov
2011-06-01 12:37 ` Amir Goldstein
2011-06-01 15:27 ` Eric Sandeen
2011-06-02 1:47 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602014704.GA16306@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sergey57@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).