From: Al Viro <viro@ZenIV.linux.org.uk>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
lacombar@gmail.com
Subject: Re: [PATCH -v2] vfs: make unlink() return ENOENT in preference to EROFS
Date: Mon, 6 Jun 2011 23:30:30 +0100 [thread overview]
Message-ID: <20110606223030.GN11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1307393893-28672-1-git-send-email-tytso@mit.edu>
On Mon, Jun 06, 2011 at 04:58:13PM -0400, Theodore Ts'o wrote:
> If user space attempts to unlink a non-existent file, and the file
> system is mounted read-only, return ENOENT instead of EROFS. Either
> error code is arguably valid/correct, but ENOENT is a more specific
> error message.
Umm... I can live with that. What about rmdir(2)? We have similar situation
there as well. If we care about one, why not the other?
Mind you, I'm not at all convinced that it matters enough to bother, but
yes, ENOENT is a bit more specific (and likelier to be handled by luserland
code).
next prev parent reply other threads:[~2011-06-06 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 20:36 [PATCH] vfs: make unlink() return ENOENT in preference to EROFS Theodore Ts'o
2011-06-06 20:45 ` Arnaud Lacombe
2011-06-06 20:58 ` [PATCH -v2] " Theodore Ts'o
2011-06-06 22:30 ` Al Viro [this message]
2011-06-06 22:48 ` Michael Tokarev
2011-06-06 23:19 ` [PATCH -v3] vfs: make unlink() and rmdir() " Theodore Ts'o
2011-06-07 0:05 ` Al Viro
2011-06-07 14:16 ` Michael Tokarev
2011-07-02 0:50 ` [-v3] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606223030.GN11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=lacombar@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).