From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH 10/15] writeback: add bdi_dirty_limit() kernel-doc Date: Wed, 08 Jun 2011 05:32:46 +0800 Message-ID: <20110607213854.641684929@intel.com> References: <20110607213236.634026193@intel.com> Cc: Jan Kara , Peter Zijlstra , Wu Fengguang To: Andrew Morton Return-path: cc: Dave Chinner cc: Christoph Hellwig cc: Cc: LKML Content-Disposition: inline; filename=writeback-task_dirty_limit-comment.patch Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Clarify the bdi_dirty_limit() comment. Acked-by: Peter Zijlstra Acked-by: Jan Kara Signed-off-by: Wu Fengguang --- mm/page-writeback.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) --- linux-next.orig/mm/page-writeback.c 2011-05-24 11:17:14.000000000 +0800 +++ linux-next/mm/page-writeback.c 2011-05-24 11:17:23.000000000 +0800 @@ -437,10 +437,17 @@ void global_dirty_limits(unsigned long * *pdirty = dirty; } -/* +/** * bdi_dirty_limit - @bdi's share of dirty throttling threshold + * @bdi: the backing_dev_info to query + * @dirty: global dirty limit in pages + * + * Returns @bdi's dirty limit in pages. The term "dirty" in the context of + * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. + * And the "limit" in the name is not seriously taken as hard limit in + * balance_dirty_pages(). * - * Allocate high/low dirty limits to fast/slow devices, in order to prevent + * It allocates high/low dirty limits to fast/slow devices, in order to prevent * - starving fast devices * - piling up dirty pages (that will take long time to sync) on slow devices *