From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
netdev@vger.kernel.org,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [RFC] breakage in sysfs_readdir() and s_instances abuse in sysfs
Date: Tue, 7 Jun 2011 22:58:34 +0100 [thread overview]
Message-ID: <20110607215834.GR11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <m1k4cy6auf.fsf@fess.ebiederm.org>
On Mon, Jun 06, 2011 at 12:03:52PM -0700, Eric W. Biederman wrote:
> Other pieces of information that should be helpful to know.
> - All sysfs directory entries for a network namespace should be
> removed from sysfs by the time sysfs_exit_ns is called.
Then why do we need to do _anything_ with ->ns[...]? Is there any problem
with postponing actual freeing of that sucker until after umount, so that
memory doesn't get reused? Since everything stale should be gone by the
point when sysfs_exit_ns() would put NULL into ->ns[...], we can as well
keep the old pointer in there - it won't match anything else for as long
as the struct net is not freed...
next prev parent reply other threads:[~2011-06-07 21:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 0:15 [RFC] breakage in sysfs_readdir() and s_instances abuse in sysfs Al Viro
2011-06-04 21:22 ` Al Viro
2011-06-04 21:55 ` Linus Torvalds
2011-06-04 22:23 ` Al Viro
2011-06-06 19:03 ` Eric W. Biederman
2011-06-07 21:58 ` Al Viro [this message]
2011-06-07 22:59 ` Al Viro
2011-06-09 1:26 ` Al Viro
2011-06-12 7:15 ` Eric W. Biederman
2011-06-12 17:59 ` Linus Torvalds
2011-06-12 18:17 ` Al Viro
2011-06-12 18:35 ` Al Viro
-- strict thread matches above, loose matches on Subject: below --
2011-06-04 22:25 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607215834.GR11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).