linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	John McCutchan <john@johnmccutchan.com>,
	Robert Love <rlove@rlove.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Race inotify_rm_watch vs umount
Date: Fri, 10 Jun 2011 15:35:50 +0100	[thread overview]
Message-ID: <20110610143550.GZ11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1307713566.2577.20.camel@localhost.localdomain>

On Fri, Jun 10, 2011 at 09:46:05AM -0400, Eric Paris wrote:
> On Fri, 2011-06-10 at 20:20 +0900, OGAWA Hirofumi wrote:
> > Hi,
> > 
> > I'm looking the race inotify_rm_watch() vs umount(). This race become the
> > cause of Oops. You can see the oops at
> > 
> > https://bugzilla.kernel.org/show_bug.cgi?id=22602
> > 
> > So, what race?
> 
> Ok, I see what you are saying, I'll see what I can do.  I'm a little
> scared to call something like iput() under a lock though.  I might be
> able to make the bigest lock a mutex and fix this....

Which lock would that be?  I don't see any good candidates in there...

  reply	other threads:[~2011-06-10 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 11:20 Race inotify_rm_watch vs umount OGAWA Hirofumi
2011-06-10 13:46 ` Eric Paris
2011-06-10 14:35   ` Al Viro [this message]
     [not found]     ` <CAGHUO11rNGU9VMAPQNdXtpQeAixFX6zxJc-tWur1McqbpYpYpQ@mail.gmail.com>
2012-03-06 21:09       ` Joseph Salisbury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610143550.GZ11521@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=eparis@redhat.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=john@johnmccutchan.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlove@rlove.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).